search

dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

Tabs have no background color #353

Closed tomdye closed 6 years ago

tomdye commented 6 years ago

Bug

screenshot 2017-11-01 17 26 10

This may be intentional

tomdye commented 6 years ago

@bitpshr @smhigley thoughts please?

smhigley commented 6 years ago

I think it makes more sense if you imagine it on a slightly off-white background, where it may look weird if that style of tab has a bg color. But again, I'd defer to Scott.

bitpshr commented 6 years ago

This was intentional for the reason @smhigley mentioned. Because the tabs are only styled with a border on the bottom, they should be able to be applied over top of any background and mesh with the underlying page. The off-white background example is more applicable, or any other realistic background color other than red.

If the tabs had aesthetics that were more "contained", a look that had a clear border around all buttons and content where it was apparent that the tabs didn't blend in with the surrounding page, I'd say we should be explicit with background coloring.

I vote we close this issue.

smhigley commented 6 years ago

Closing in favor of leaving tabs transparent