search

dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

Text color on select / combobox are a different colour #355

Closed tomdye closed 6 years ago

tomdye commented 6 years ago

Bug

screenshot 2017-11-01 17 28 19

I would expect Select to have the same font styling

smhigley commented 6 years ago

@tomdye I believe this is related to #298. Select currently doesn't support a placeholder (since native select doesn't support one), so the dark text in Select is an actual value, while the greyed text in Timepicker/Combobox is the placeholder text. If you choose a value for the latter widgets, you'll see the text should match.

The plan is to add placeholder support to custom Select widgets, which should solve this as well.

tomdye commented 6 years ago

thanks for the update @smhigley . is it worth keeping open for future reference ?

smhigley commented 6 years ago

Hm, I think it's a duplicate of #298, since it's not actually the styling that differs but the existence of a placeholder. I do plan to get a PR in for both today though, so not a big deal either way.

tomdye commented 6 years ago

ok, no worries, happy to close