search

dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

Combo / Time picker / Listbox does not have a max height and are not scrollable #443

Closed tomdye closed 6 years ago

tomdye commented 6 years ago

Bug

The listboxes presented by timepicker / combo box etc do not have a max height and as such they can run right off of a screen. This makes it very hard for a user to get to the value they require. They also do not have a scrollbar and as such you cannot scroll through results without losing your place on the page.

screenshot 2018-02-02 14 19 55

smhigley commented 6 years ago

I set a max-height to test keyboard scrolling behavior in development, so the requisite styles and behavior are there. All it would need is a max-height style. I'm leery of putting this directly in our theme CSS though, since the best max-height can be very context-dependent.

Would you be OK with adding this to our examples, or do you want it directly in the theme? Alternatively, do you think we need to add logic to the widget itself to prevent it going off-screen?

tomdye commented 6 years ago

I think that it needs to just work as expected out of the box. Perhaps a max height property as you suggested defaulting to a sensible value.

tomdye commented 6 years ago

Issue moved to dojo/themes #7 via ZenHub