Select: onChange event differences

tomdye commented 5 years ago

Enhancement

The native / non-native elements currently have different onChange events. The native version requires a getOptionValue property to be implemented whereas the non-native does not. We should normalise these two onChange events and the API in general for Select.

Update [by @sammenza]: Specifically Select widget should have the following changed:

Update options property to be of type {value: string, label?: string}[]
Allow select to accept <option> child nodes
Remove getOptionValue property from Select widget

tomdye commented 5 years ago

This is part of a larger piece of work to align select / combo box apis and to update callbacks to use onValue

samends commented 5 years ago

Why is there a native and non native version in the first place?

samends commented 5 years ago

The getOptionLabel would also become repetitive in this case so I'm taking out that property as well

tomdye commented 4 years ago

This has been fixed via https://github.com/dojo/widgets/pull/962

dojo / widgets

Select: onChange event differences #675