search

dojoengine / book

The Dojo Book
https://book.dojoengine.org
MIT License
38 stars 71 forks source link

feat(#261): add new folder with deployment commands and delete deploy… #271

Open juandiegocv27 opened 1 month ago

juandiegocv27 commented 1 month ago

This is the issue #261.

Just modified and add some features for Slot CLI documentation that will bring great context with:

-deleted deployments page. -added create, delete, update, describe, list, logs and help command pages.

image

@kariy.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
book ✅ Ready (Inspect) Visit Preview Jun 4, 2024 7:03am
juandiegocv27 commented 1 month ago

Hi, @kariy I have an error, in this part, could you check it, I'll fix it as soon as possible

juandiegocv27 commented 1 month ago

hey @juandiegocv27 thanks for the work!

can you also update the sidebar config so that the new pages would be accessible from the sidebar ?

Screenshot 2024-05-13 at 9 12 24 AM

Ok sure 🫡

juandiegocv27 commented 1 month ago

Hi @kariy, I just fix it, and agreggate some features, hope for feedback

juandiegocv27 commented 3 weeks ago

HI @kariy @milancermak, is this PR is still relevant? Please let me know if there's anything else you’d like me to add or if you have any feedback. I'm happy to make any changes you need. Thanks (plus: the check failed beacuse I erased the file that you recommend me to eliminate).

ponderingdemocritus commented 3 weeks ago

@juandiegocv27 could you fix the conflict

juandiegocv27 commented 3 weeks ago

@ponderingdemocritus sure, but, talking in discord with @kariy told me to erase the file deployments.md, so I could return it, but all that I do was put more stuff and make deployments a folder. Give me a moment and I'll return it hehe

juandiegocv27 commented 2 weeks ago

@ponderingdemocritus @kariy @milancermak @ptisserand, just resolved conflicts, plus update the code to the last comit of dojo book

juandiegocv27 commented 2 weeks ago

@ponderingdemocritus @kariy @milancermak @ptisserand Fix all the code and ready to merge: image

waiting for more feedback 😎🚀

juandiegocv27 commented 6 days ago

Thanks for the work here @juandiegocv27!

Some important points:

  1. consistency: slot should be formatted with consistency as sometimes you use Slot and sometimes Slot.

  2. formatting: I've left some commands on formatting, not on all the lines that require changes, you may do a general review of formatting.

@glihm thanks a lot for the feedback, I'll work on it as fast as possible ⚡️