fix: utils - change way to compute selector hash

MartianGreed commented 3 months ago

Closes #247

Introduced changes

Changes way to get component from event hash.

This will not fix the recs issue about Map receiver.

-

Checklist

[x] Linked relevant issue
[x] Added relevant tests
[x] Performed self-review of the code

Summary by CodeRabbit

New Features
- Introduced enhanced logging and error handling in entity management functions.
- Added a new test suite using Vitest for utility functions to ensure reliability.
- Implemented new constants and functions for improved event filtering and component handling.
Bug Fixes
- Refined error handling in component setting logic to prevent issues during execution.
Chores
- Updated the testing framework from Jest to Vitest, enhancing testing capabilities.
- Added coverage reporting for utility functions to improve quality assurance.

coderabbitai[bot] commented 3 months ago

[!WARNING]

Rate limit exceeded

@MartianGreed has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 0 seconds before requesting another review.

How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

Commits
Files that changed from the base of the PR and between 8f0d4befac513f3710ec4b3fc18771be01cb20a6 and ead2a2da8253b16a004d96ba6f909ad61268a4d1.

Walkthrough

The recent changes enhance the functionality and maintainability of the Dojo.js codebase, focusing on improved logging, error handling, and testing capabilities. Key modifications include refining entity management functions, explicitly defining types for better clarity, and migrating the testing framework to Vitest, which streamlines coverage reporting and strengthens overall reliability.

Changes

Files	Change Summary
`packages/state/src/recs/index.ts`	Improved logging and refined error handling in entity functions.
`packages/state/src/utils/index.ts`	Defined return type for `convertValues` and enhanced code readability.
`packages/utils/coverage/.tmp/...`	Introduced JSON file for test coverage results.
`packages/utils/package.json`	Updated testing framework to Vitest and added coverage reporting scripts.
`packages/utils/src/_test_/utils/...`	New unit tests for utility functions using Vitest.
`packages/utils/src/utils/index.ts`	Added constants and refactored functions for better event handling.

Assessment against linked issues

Objective	Addressed	Explanation
Components should always be in sync with Torii (##247)	❌	Changes improve logging and error handling but do not directly resolve sync issues.

Poem

🐰 In the code where rabbits hop,
Improvements made, we can’t stop!
Logs now sing with every call,
Error handling stands tall.
A testing shift, so bright and new,
Hooray for changes, cheers to you! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

ponderingdemocritus commented 3 months ago

Looks good other than that, nice iteration

dojoengine / dojo.js