search

dojoengine / dojo

Dojo is a toolchain for building provable games and autonomous worlds with Cairo
https://dojoengine.org
Apache License 2.0
407 stars 164 forks source link

Better testing for gRPC #1570

Open broody opened 7 months ago

broody commented 7 months ago

Currently, there isn't very good coverage for gRPC. Would be great to have tests that covers all queries and subscriptions.

gianalarcon commented 7 months ago

I would like to work on this as well =)

glihm commented 3 months ago

@gianalarcon how are you doing? Is this something you still want to tackle? We've to setup a whole test suite for gRPC automated testing. @lambda-0x should take over on some part of Torii, but if you've already started something let's sync on that! 👍

gianalarcon commented 2 months ago

All yours @glihm @lambda-0x . I would like to contribute in upcoming issues related to torii(graphql, grpc).

PedroRosalba commented 2 months ago

@broody Can I work on this?

broody commented 2 months ago

@broody Can I work on this?

Ah I've been out of the loop, I think @lambda-0x is taking over this, but deferring to @glihm sensei

Supa-mega commented 4 weeks ago

hello @broody can i also hop on this

Kelvin01 commented 3 weeks ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I've work with grpc a couple of times in the past. For UT usually what I do is creating a local grpc for listening the requests and I'd return some mocked data in order to increase coverage and make the code falls to the scenarios I want to test.

CollinsC1O commented 2 weeks ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm a frontend and a blockchain developer. I will love to work on this

llamitaOnfire commented 5 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I’m a Computer Engineering student and a web developer with a growing interest in blockchain. I’ve recently started contributing to open source and am passionate about projects that encourage innovation and collaboration. My background in Computer Engineering and my focus on learning new technologies, including gRPC, aligns well with this issue. While I’m relatively new to open source, I’m eager to apply my skills, gain practical experience with gRPC, and contribute meaningfully to this project

How I plan on tackling this issue

Plan for Tackling the Issue:

Familiarize myself with the existing codebase and testing framework: I will review the current implementation of gRPC queries and subscriptions to understand the current test coverage and where gaps exist. Identify all gRPC queries and subscriptions: I’ll document all the queries and subscriptions that need coverage, ensuring that none are missed. Write comprehensive tests: Using this list, I will write unit tests and integration tests to ensure that all gRPC queries and subscriptions are properly tested. Ensure scalability: I will focus on writing tests that not only validate functionality but also handle edge cases and scalability concerns. Submit a PR for review: Once the tests are written, I will submit a pull request for feedback and refinement. Looking forward to contributing and helping improve the test coverage for gRPC!