Tx failing silently when failing to commit db tx

dojoengine / dojo

Dojo is a toolchain for building provable games and autonomous worlds with Cairo

https://dojoengine.org

Apache License 2.0

388 stars 147 forks source link

Tx failing silently when failing to commit db tx #1650

Open notV4l opened 4 months ago

notV4l commented 4 months ago

Describe the bug When katana is out of space for db, this error occurs : ERROR node: failed to mine block: failed to commit db transaction: Input/output error

It seems the tx fails silently & waitForTransaction timeout

There might be a similar issue with other DatabaseError.s

Expected behavior tx should be rejected with useful error msg

kariy commented 4 months ago

I don't think the expected behaviour is correct. This is an issue that is beyond the scope of the RPC specs, and the rejected status is not meant to describe unexpected cases like this, as this issue is completely unrelated to the tx itself.

One way I could think of to handle hardware issues like this, is to retry the mining process again, instead of just dropping the block when it failed to mine.