Closed rsodre closed 6 months ago
I've been into sozo lately, can i take this one?
@rsodre thanks for the detailed report.
@fabrobles92 thanks you for interest in this issue, but i think this is related to fix done in #1790. i will confirm that and let you know.
this is caused due to two issues:
but onchain they are in this format:
this is how sozo handles case conversion: https://github.com/dojoengine/dojo/blob/e9fab2caf970621ed8311330f3752dc9635f60d7/crates/dojo-world/src/migration/world.rs#L36-L46
@glihm how should we fix this?
@glihm how should we fix this?
We should wait the rework that will use the model's selector instead of their name actually. To directly take the name without modification and having it's selector.
Oh ok, that's why I couldn't reproduce on the spawn-and-move
example without additional contracts.
with merge of #1822 this issue is fixed.
for the second issue i mentioned of sozo unnecessarily trying to migrate few contracts @glihm should I create a new issue to track it? or if there is already an issue for the rework you mentioned i can comment this there.
the second issue should be fixed with changes mentioned in #1629
Describe the bug Runing
sozo apply
twice replaces the manifest addresses tonull
To Reproduce
Using Dojo 0.6.0
Expected behavior if
sozo migrate apply
is updated, it should not write to manifestsScreenshots
Console outputs running from this repo: https://github.com/funDAOmental/pistols/tree/wallet
Look at the greps from
manifest.json
Terminal 1:
Terminal 2: