Open rsodre opened 1 month ago
atm in sozo migrate plan
we just generate the manifest files and print the addresses that everything will have (since they can be deterministically calculated).
we don't simulate any of the transaction to actually verify the data.
it might be possible to detect obvious bad syntax as you mentioned. but i am not sure it would be possible to detect all kinds of error that could be possible during actual deployment.
i.e. things like "$contract_address:::::::::::::pistols-token_duelist", # duelist token
we can try to simulating a tranction which does the whole deployment in a single transaction but i am not sure about how good the error message from that would be, and even that would require significant refactor to achieve.
Describe the bug
sozo migrate plan
does not validateinit_calldata
arguments countTo Reproduce
init_calldata
it's overlay filesozo migrate plan
, no errors will appearsozo migrate apply
, it will failExpected behavior
apply
should be detected onplan
.Additional context
This is a valid config from my contract
minter.toml
:Changing to this will not raise a
plan
error but will fail onapply
:On the other hand, if I change the first argument to something invalid,
plan
will understand and raise an error: