search

dojoengine / dojo

Dojo is a toolchain for building provable games and applications
https://dojoengine.org
Apache License 2.0
418 stars 173 forks source link

ci: Github Action for `cargo-udeps` failed #2342

Closed github-actions[bot] closed 3 weeks ago

github-actions[bot] commented 2 months ago

cargo-udeps failed: https://github.com/dojoengine/dojo/actions/runs/10549011382 Reference: branch refs/heads/main (commit 194438922a028dac6bf40533ce139dd742809902).

ShantelPeters commented 2 months ago

Please can I be assigned to this issue?

ScottyDavies commented 2 months ago

can i work on this?

wugalde19 commented 2 months ago

Hi @glihm William here from 🇨🇷 and part of the Dojo Coding Community

Quick question, Do you really think that was a false-positive as mentioned in the error? (just a matter of adding package.metadata.cargo-udeps.ignore in Cargo.toml)

Or did something really happen with the dependencies and has to be fixed/cleaned up this week?

image
lambda-0x commented 2 months ago

@wugalde19 it would be hard to tell just from looking at the error, from my experience udeps dont have false positives and most likely we have some dependencies where they are not required