search

dojoengine / dojo

Dojo is a toolchain for building provable games and applications
https://dojoengine.org
Apache License 2.0
420 stars 175 forks source link

opt(torii-grpc): parallelize queries #2443

Closed Larkooo closed 1 month ago

Larkooo commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

Ohayo, sensei! The recent changes enhance the DojoWorld implementation by incorporating parallel processing for database queries and entity mapping. The code now employs the Rayon library to parallelize the mapping of database rows to entities, improving performance with large datasets. Key updates include grouping entities by model IDs for efficient querying and utilizing batch processing with SQL IN clauses, significantly reducing database calls.

Changes

File Path Change Summary
crates/torii/grpc/src/server/mod.rs Introduced parallel processing for database queries and entity mapping using Rayon. Grouped entities by model IDs for efficient querying and refactored row mapping to leverage parallel iteration. Modified functions to accept parameters for table names and relation columns.
crates/torii/grpc/Cargo.toml Added itertools.workspace = true to include the itertools crate in the workspace, enhancing data handling capabilities.

Possibly related PRs

Suggested reviewers

Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 17dfab363db509444173cfabbbd5042f80551ff9 and 51c654befb41fce6d729097b14d51435c669b1a2.
Files ignored due to path filters (1) * `Cargo.lock` is excluded by `!**/*.lock`
Files selected for processing (1) * crates/torii/grpc/src/server/mod.rs (16 hunks)
Files skipped from review as they are similar to previous changes (1) * crates/torii/grpc/src/server/mod.rs
---
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 49.01961% with 78 lines in your changes missing coverage. Please review.

Project coverage is 68.38%. Comparing base (7c5a1f5) to head (51c654b). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/torii/grpc/src/server/mod.rs 49.01% 78 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2443 +/- ## ========================================== + Coverage 68.21% 68.38% +0.16% ========================================== Files 365 365 Lines 48018 47973 -45 ========================================== + Hits 32757 32805 +48 + Misses 15261 15168 -93 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.