search

dojoengine / dojo

Dojo is a toolchain for building provable games and autonomous worlds with Cairo
https://dojoengine.org
Apache License 2.0
407 stars 164 forks source link

refactor-opt(torii-grpc): subscriptions no db fetch #2455

Closed Larkooo closed 1 week ago

Larkooo commented 1 week ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

Ohayo, sensei! The changes in this pull request involve renaming fields in several structs to improve clarity, specifically changing entity to ty to better reflect their purpose as type descriptors. Additionally, the Service struct in multiple files has been simplified by removing dependencies on database connections and model caches, streamlining the service's construction and functionality. The publish_updates methods have also been refactored to rely on in-memory data rather than database queries, enhancing the overall efficiency of the code.

Changes

Files Change Summary
crates/torii/core/src/query_queue.rs, crates/torii/core/src/sql.rs Renamed entity to ty in DeleteEntityQuery struct and related data structures, reflecting a shift towards a more structured representation of entity types.
crates/torii/grpc/src/server/subscriptions/entity.rs, .../event_message.rs Simplified Service struct by removing Pool<Sqlite> and Arc<ModelCache> dependencies, and refactored publish_updates methods to utilize in-memory data.

Possibly related PRs

Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between f795c3af6634c3a8c1bd26ed13667e29d065abbe and d67dc7558597553a25868e804e38ac463cf97ed1.
Files selected for processing (2) * crates/torii/grpc/src/server/subscriptions/entity.rs (3 hunks) * crates/torii/grpc/src/server/subscriptions/event_message.rs (3 hunks)
Files skipped from review as they are similar to previous changes (2) * crates/torii/grpc/src/server/subscriptions/entity.rs * crates/torii/grpc/src/server/subscriptions/event_message.rs
---
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.

Project coverage is 68.36%. Comparing base (82a23a5) to head (d67dc75). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ates/torii/grpc/src/server/subscriptions/entity.rs 20.00% 8 Missing :warning:
...rii/grpc/src/server/subscriptions/event_message.rs 22.22% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2455 +/- ## ========================================== + Coverage 68.29% 68.36% +0.07% ========================================== Files 365 365 Lines 48034 47951 -83 ========================================== - Hits 32805 32782 -23 + Misses 15229 15169 -60 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.