Open Larkooo opened 1 week ago
Ohayo, sensei! The changes in this pull request introduce the tempfile
crate into the workspace configuration across various modules. Additionally, an Executor
component is integrated into the testing modules, enhancing the management of database operations through asynchronous handling. This shift replaces previous direct instantiations of the Sql
database with a more structured approach, allowing for concurrent execution and improved testing capabilities.
File Path | Change Summary |
---|---|
crates/torii/core/Cargo.toml | Added tempfile.workspace = true to include the tempfile crate in the workspace configuration. |
crates/torii/graphql/Cargo.toml | Added tempfile.workspace = true to include the tempfile crate in the workspace configuration. |
crates/torii/core/src/sql_test.rs | Introduced Executor for asynchronous database operations, added setup_sqlite_pool function, and updated test functions to utilize the Executor , including new assertions for event message counts. |
crates/torii/graphql/src/tests/mod.rs | Modified spinup_types_test to incorporate Executor , changing database execution logic to support asynchronous operations with a persistent SQLite database. |
crates/torii/grpc/src/server/tests/entities_test.rs | Integrated Executor into test_entities_queries , altering database connection creation and execution flow for concurrent processing. |
crates/torii/libp2p/src/tests.rs | Integrated Executor into test functions, modifying the Sql instantiation to include a sender parameter and removing a test for publish event verification. |
QueryQueue
and introduces a new QueryType
enum, which is relevant as the main PR adds the tempfile
crate to the workspace, potentially impacting how queries are managed in the context of temporary file usage.QueryQueue
to handle entity deletions, which may relate to the changes in the main PR regarding workspace management and how entities are processed in tests.tempfile
crate's integration.
Summary by CodeRabbit
New Features
Executor
component for improved management of database operations.tempfile
crate across multiple components.Bug Fixes
Refactor
Executor
for handling asynchronous queries.Executor
for improved database execution logic.