dojoengine / dojo

Dojo is a toolchain for building provable games and autonomous worlds with Cairo
https://dojoengine.org
Apache License 2.0
407 stars 164 forks source link

opt(torii-core): move off queryqueue for executing tx #2460

Open Larkooo opened 1 week ago

Larkooo commented 1 week ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

Ohayo, sensei! The changes in this pull request introduce the tempfile crate into the workspace configuration across various modules. Additionally, an Executor component is integrated into the testing modules, enhancing the management of database operations through asynchronous handling. This shift replaces previous direct instantiations of the Sql database with a more structured approach, allowing for concurrent execution and improved testing capabilities.

Changes

File Path Change Summary
crates/torii/core/Cargo.toml Added tempfile.workspace = true to include the tempfile crate in the workspace configuration.
crates/torii/graphql/Cargo.toml Added tempfile.workspace = true to include the tempfile crate in the workspace configuration.
crates/torii/core/src/sql_test.rs Introduced Executor for asynchronous database operations, added setup_sqlite_pool function, and updated test functions to utilize the Executor, including new assertions for event message counts.
crates/torii/graphql/src/tests/mod.rs Modified spinup_types_test to incorporate Executor, changing database execution logic to support asynchronous operations with a persistent SQLite database.
crates/torii/grpc/src/server/tests/entities_test.rs Integrated Executor into test_entities_queries, altering database connection creation and execution flow for concurrent processing.
crates/torii/libp2p/src/tests.rs Integrated Executor into test functions, modifying the Sql instantiation to include a sender parameter and removing a test for publish event verification.

Possibly related PRs

Suggested reviewers


📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between b708081b1879fdd145cde2fe45a51550cf7c4e84 and 7758cf9cb0efc86bb6984d4437c5d6d4345683e1.
📒 Files selected for processing (1) * crates/torii/core/src/sql_test.rs (12 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * crates/torii/core/src/sql_test.rs
---
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.