dojoengine / dojo

Dojo is a toolchain for building provable games and applications
https://dojoengine.org
Apache License 2.0
420 stars 175 forks source link

chore: use the new Katana runner proc macro #2465

Closed kariy closed 1 month ago

kariy commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

Ohayo, sensei! This pull request introduces significant modifications to the testing framework by transitioning from the KatanaRunner and its configuration to a more streamlined approach using the katana_runner::test attribute macro. The changes affect multiple test files, updating function signatures to accept a &RunnerCtx parameter and simplifying test setups by removing the manual instantiation of KatanaRunner. This results in a cleaner and more efficient testing process across various modules.

Changes

Files Change Summary
bin/sozo/tests/register_test.rs, bin/sozo/tests/test_migrate.rs, crates/dojo-world/src/contracts/model_test.rs, crates/dojo-world/src/contracts/world_test.rs, crates/dojo-world/src/manifest/manifest_test.rs Updated test functions to use katana_runner::test macro and modified signatures to accept &RunnerCtx instead of instantiating KatanaRunner.
crates/katana/runner/macro/src/config.rs, crates/katana/runner/macro/src/entry.rs, crates/katana/runner/tests/runner.rs Altered configurations to utilize syn::Expr instead of syn::Lit for various fields, enhancing flexibility in expression handling.
crates/sozo/ops/src/tests/auth.rs, crates/sozo/ops/src/tests/call.rs, crates/sozo/ops/src/tests/migration.rs, crates/sozo/ops/src/tests/model.rs, crates/sozo/ops/src/tests/utils.rs, crates/torii/core/src/sql_test.rs, crates/torii/grpc/src/server/tests/entities_test.rs Refactored test functions to use katana_runner::test attributes, removing KatanaRunner instantiation and updating signatures to include &RunnerCtx.

Possibly related PRs

Suggested labels

sozo


Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 21c9b96ebb2962b97baf78e0161ddf39c7b46419 and c67b0bd788e386c2e18467236fc61bce1d650dc3.
Files selected for processing (1) * crates/sozo/ops/src/tests/utils.rs (3 hunks)
Files skipped from review as they are similar to previous changes (1) * crates/sozo/ops/src/tests/utils.rs
---
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
> [!TIP] >
> Early access features: enabled > > We are currently testing new code review model(s) that may lead to higher noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. > > Note: > > - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. > >
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.44%. Comparing base (bb149b7) to head (c67b0bd). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/katana/runner/macro/src/config.rs 83.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2465 +/- ## ========================================== + Coverage 68.42% 68.44% +0.01% ========================================== Files 368 368 Lines 48197 48176 -21 ========================================== - Hits 32981 32975 -6 + Misses 15216 15201 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.