search

dojoengine / dojo

Dojo is a toolchain for building provable games and applications
https://dojoengine.org
Apache License 2.0
420 stars 175 forks source link

refactor(katana-primitives): replace `HashMap` with `BTreeMap` in state updates and genesis types #2469

Closed kariy closed 1 month ago

kariy commented 1 month ago

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 month ago

Walkthrough

Ohayo, sensei! The changes in this pull request primarily involve replacing HashMap with BTreeMap across various modules in the codebase. This transition affects data structures used for managing state updates, contract storage, and related functionalities. Additionally, the field contract_updates has been renamed to deployed_contracts in multiple locations, reflecting a shift in how deployed contracts are tracked and processed.

Changes

Files Change Summary
crates/saya/core/src/prover/* Replaced instances of HashMap with BTreeMap for managing storage updates and modified references from contract_updates to deployed_contracts. Updated serialization tests accordingly.
crates/saya/provider/src/rpc/state.rs Changed contract_entry to use BTreeMap instead of HashMap and updated the output structure from out.contract_updates to out.deployed_contracts.

Possibly related PRs

Suggested reviewers

Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between f46c01127b15bb49391dc688cfccb1eae2a36a96 and d9cb0a4e8df5e13c3893dcd69883e18d6a679390.
Files selected for processing (1) * crates/saya/core/src/prover/program_input.rs (10 hunks)
Files skipped from review as they are similar to previous changes (1) * crates/saya/core/src/prover/program_input.rs
---
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 88.88889% with 12 lines in your changes missing coverage. Please review.

Project coverage is 68.46%. Comparing base (b598b07) to head (d9cb0a4). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/saya/src/tests.rs 0.00% 5 Missing :warning:
crates/saya/core/src/prover/program_input.rs 84.21% 3 Missing :warning:
crates/saya/provider/src/rpc/state.rs 0.00% 2 Missing :warning:
crates/katana/rpc/rpc-types/src/state_update.rs 0.00% 1 Missing :warning:
crates/saya/core/src/prover/state_diff.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2469 +/- ## ======================================= Coverage 68.45% 68.46% ======================================= Files 368 368 Lines 48162 48178 +16 ======================================= + Hits 32971 32986 +15 - Misses 15191 15192 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.