fix: ensure `log` crate output is shown with `tracing`

glihm commented 1 month ago

Summary by CodeRabbit

New Features
- Introduced a new logging framework to enhance logging capabilities across the application.
Improvements
- Updated logging configuration to reduce verbosity for specific components, improving log clarity.
- Simplified logging setup process for better maintainability.
Bug Fixes
- Resolved issues related to logging initialization to ensure robust logging behavior.

coderabbitai[bot] commented 1 month ago

Walkthrough

Ohayo, sensei! The recent changes involve updates to the Cargo.toml file, enhancing dependency management by upgrading the tracing crate and introducing tracing-log. The logging configurations in the bin/saya, bin/sozo, and bin/katana projects have been refined to adjust log verbosity and integrate the LogTracer, improving the overall logging infrastructure. These modifications collectively aim to streamline logging practices across the projects.

Changes

Files	Change Summary
`Cargo.toml`	Updated `tracing` from `0.1.34` to `0.1.38` with features and added `tracing-log` as a new dependency. Adjusted workspace declarations for `tracing-log` in `bin/sozo`, `bin/saya`, and `bin/katana`.
`bin/saya/src/args/mod.rs`	Modified `init_logging` method to change logging filter and added `LogTracer::init()` for logging initialization.
`bin/sozo/src/args.rs`	Updated `init_logging` to include `salsa=off` in logging configuration and transitioned to using `FmtSubscriber`.
`bin/katana/src/cli/node.rs`	Added `LogTracer::init()` to initialize logging infrastructure in `NodeArgs`.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SayaArgs
    participant SozoArgs
    participant NodeArgs
    participant LogTracer

    User->>SayaArgs: Initialize logging
    SayaArgs->>LogTracer: LogTracer::init()
    LogTracer-->>SayaArgs: Logging initialized
    SayaArgs->>SayaArgs: Set logging filter

    User->>SozoArgs: Initialize logging
    SozoArgs->>LogTracer: LogTracer::init()
    LogTracer-->>SozoArgs: Logging initialized
    SozoArgs->>SozoArgs: Set logging filter

    User->>NodeArgs: Initialize logging
    NodeArgs->>LogTracer: LogTracer::init()
    LogTracer-->>NodeArgs: Logging initialized
    NodeArgs->>NodeArgs: Set logging filter

:placard: Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.45%. Comparing base (8453b63) to head (8eaa1c2). Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
bin/saya/src/args/mod.rs	0.00%	3 Missing :warning:
bin/katana/src/cli/node.rs	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2477 +/- ## ========================================== - Coverage 68.45% 68.45% -0.01% ========================================== Files 368 368 Lines 48139 48153 +14 ========================================== + Hits 32955 32961 +6 - Misses 15184 15192 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dojoengine / dojo