dojoengine / origami

The magic of origami is in seeing a single piece of cairo evolve into a masterpiece through careful folds.
MIT License
32 stars 16 forks source link

[Feature]: ERC-721 Metadata hooks #79

Open rsodre opened 1 week ago

rsodre commented 1 week ago

Feature Request

Add a hook to Origami ERC-721 implementation to customize token_uri().

Proposed Solution

Alternatives

Teh only way to customize the token uri is to clone erc721_metadata_component and use it on the token contract, instead of using Origami's own.

Related Code

OpenZeppelin has similar hooks at their ERC721 and ERC20 implementations

Additional context

This hook is required to allow fully on-chain metadata.

If the feature is accepted, would you be willing to contribute it?

ooochoche commented 1 week ago

@rsodre I could work on this since it is yet to be assigned

rsodre commented 1 week ago

@rsodre I could work on this since it is yet to be assigned

I'm not an admin on this repository. But I'm already working on it for a personal project, and proposing a PR with my changes.