dojot / device-manager

Device management service for dojot
http://www.dojot.com.br
Apache License 2.0
0 stars 1 forks source link

[0.4.4] - Refresh "updated" column of template every time template structure changes #168

Closed canattofilipe closed 4 years ago

canattofilipe commented 4 years ago
canattofilipe commented 4 years ago

I'm not sure about that going to 0.4.4, I think it's not a good idea.

Ok, so I will close it.

mprevide commented 4 years ago

I'm not sure about that going to 0.4.4, I think it's not a good idea.

Ok, so I will close it.

This is not just my decision... I think we can discuss it with other people... @canattofilipe

canattofilipe commented 4 years ago

I'm not sure about that going to 0.4.4, I think it's not a good idea.

Ok, so I will close it.

This is not just my decision... I think we can discuss it with other people... @canattofilipe

Hmm OK, So there goes my opinion, the device-managerservice is one of the dojot's core service, so every change on it should be reviewed carefully and then covered by E2E tests by QA team.

This PR introduces a very simple fix in order to keep template's "updated" attribute up to date after structure changes (for example add new attribute or remove a meta-attribute), this service are being used without this fix for a long time and none issue was registered, so in my opinion we can be conservative and available it only in 0.5.0 version.