Closed LuanEdCosta closed 2 years ago
The CI stuck and I don't know why. I think I need some help here to run the CI or to run tests locally to check if everything is fine.
Merging #201 (d7436a2) into development (7fb82f3) will increase coverage by
0.50%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## development #201 +/- ##
===============================================
+ Coverage 82.48% 82.99% +0.50%
===============================================
Files 28 28
Lines 2490 2529 +39
===============================================
+ Hits 2054 2099 +45
+ Misses 436 430 -6
Flag | Coverage Δ | |
---|---|---|
Device-manager | 82.99% <100.00%> (+0.50%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
DeviceManager/DatabaseModels.py | 86.27% <100.00%> (+0.98%) |
:arrow_up: |
DeviceManager/TemplateHandler.py | 63.98% <100.00%> (+0.96%) |
:arrow_up: |
tests/test_device_handler.py | 99.71% <100.00%> (+0.01%) |
:arrow_up: |
tests/test_template_handler.py | 100.00% <100.00%> (ø) |
|
DeviceManager/DeviceHandler.py | 65.50% <0.00%> (+0.31%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Please check if the PR fulfills these requirements
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature
What is the current behavior? (You can also link to an open issue here) You can create multiple devices and templates with the same label
What is the new behavior (if this is a feature change)? Now the label of devices and templates are unique.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) Yes.
Is there any issue related to this PR in other repository? (such as dojot/dojot) https://dojot.atlassian.net/browse/DOJOT-75 https://dojot.atlassian.net/browse/DOJOT-76