ademirr commented 1 year ago

Please check if the PR fulfills these requirements
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

What is the current behavior? (You can also link to an open issue here)

can not disabled device

What is the new behavior (if this is a feature change)?

now device can be disabled

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

yes

Is there any issue related to this PR in other repository? (such as dojot/dojot)

https://dojot.atlassian.net/browse/DOJOT-141 https://dojot.atlassian.net/browse/DOJOT-143

Other information:

codecov[bot] commented 1 year ago

Codecov Report

Base: 83.02% // Head: 83.15% // Increases project coverage by +0.13% :tada:

Coverage data is based on head (1bcea1e) compared to base (eedf4e8). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## development #205 +/- ## =============================================== + Coverage 83.02% 83.15% +0.13% =============================================== Files 28 28 Lines 2533 2553 +20 =============================================== + Hits 2103 2123 +20 Misses 430 430 ``` | Flag | Coverage Δ | | |---|---|---| | Device-manager | `83.15% <100.00%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dojot#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/dojot/device-manager/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dojot) | Coverage Δ | | |---|---|---| | [tests/test\_import\_handler.py](https://codecov.io/gh/dojot/device-manager/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dojot#diff-dGVzdHMvdGVzdF9pbXBvcnRfaGFuZGxlci5weQ==) | `100.00% <ø> (ø)` | | | [DeviceManager/DatabaseModels.py](https://codecov.io/gh/dojot/device-manager/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dojot#diff-RGV2aWNlTWFuYWdlci9EYXRhYmFzZU1vZGVscy5weQ==) | `86.40% <100.00%> (+0.13%)` | :arrow_up: | | [DeviceManager/SerializationModels.py](https://codecov.io/gh/dojot/device-manager/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dojot#diff-RGV2aWNlTWFuYWdlci9TZXJpYWxpemF0aW9uTW9kZWxzLnB5) | `85.60% <100.00%> (+0.11%)` | :arrow_up: | | [tests/test\_device\_handler.py](https://codecov.io/gh/dojot/device-manager/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dojot#diff-dGVzdHMvdGVzdF9kZXZpY2VfaGFuZGxlci5weQ==) | `99.72% <100.00%> (+0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dojot). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dojot)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.