Dokan 0.7.3 support - Githubissues

dokan-dev / dokan-delphi

Dokan Delphi Wrapper

MIT License

58 stars 22 forks source link

Dokan 0.7.3 support #1

Closed landrix closed 9 years ago

landrix commented 9 years ago

Dokan 0.7.3 support
Win32, Win64 support

Liryna commented 9 years ago

Thanks of the PR I am not really familiar with delphi but it seems to be good :smiley: Are you only using dokan with delphi ?

We will probably wait the @Maxhy review before merging it.

landrix commented 9 years ago

i try dokan with delphi and .net

At the moment I still check, it would be better to create the mountpoint on the client or on server over network-share. But I'm still missing a few basics (see also my question in dokan google group)

Maxhy commented 9 years ago

Thanks for this PR @landrix. This looks good, except Mirror.dproj file:

Excluded package list looks too specific to your environment
Import Project declarations add new build tool dependencies (CodeGear, Embarcadero). Or did I misread the code?

landrix commented 9 years ago

There are no dependencies. The exclude and import parts can be removed. Should I start a new pull request?

landrix commented 9 years ago

or remove the complete dproj file

Maxhy commented 9 years ago

Ok, well I believe the prerequisite to open Dproj file will be to have Embarcadero installed then. After thinking we can keep it for other peoples using this tool, today there is no dproj file so this is not a regression. I will merge as it is. Thank you (btw to update a PR you just have to push new commits to your branch, no need for a new PR).