search

dokan-dev / dokan-dotnet

Dokan DotNet Wrapper
http://dokan-dev.github.io
MIT License
462 stars 116 forks source link

moved .net46 to .net 461 and added .net6.0-window in the TFM #295

Closed TrabacchinLuigi closed 2 years ago

TrabacchinLuigi commented 2 years ago

added .net6 compatibility, upped .net4.6 to 4.6.1, and removed the need to sign the test assembly

Liryna commented 2 years ago

Thanks for the pull request! Looks like there is an issue with the CI 😢 but it does have 4.6.1 https://www.appveyor.com/docs/windows-images-software/ https://ci.appveyor.com/project/Liryna/dokan-dotnet/builds/42829412/job/rijcjmdmx09eff04

TrabacchinLuigi commented 2 years ago

it looked like .net 6 was missing, but, it's really not my area of expertise

RenatoCaenaro commented 2 years ago

The problema is net6 (core), looks like installed only in the vm for visualstudio 2022 according to: https://www.appveyor.com/docs/windows-images-software/ The current configuration use a vs2019 vm right?

Liryna commented 2 years ago

True! Well found. @TrabacchinLuigi Can you update the appveyor file at the root in your pull request to change 2019 to 2022?

TrabacchinLuigi commented 2 years ago

why are the tests run also in release mode?

Liryna commented 2 years ago

Garbage collector is behaving differently on release. It has proven to be very helpful to have both run.

Looks like it is building but none are succeeding :(

TrabacchinLuigi commented 2 years ago

And how is garbage collection tested ? :raised_eyebrow: Nevermind i'll revert that part

Liryna commented 2 years ago

For example when we moved to V2 we had the GC releasing the native memory only on release https://github.com/dokan-dev/dokan-dotnet/issues/280