search

dokan-dev / dokan-dotnet

Dokan DotNet Wrapper
http://dokan-dev.github.io
MIT License
462 stars 116 forks source link

Support pagingIo in mirror.net #298

Closed TrabacchinLuigi closed 2 years ago

TrabacchinLuigi commented 2 years ago

Little refactor to remove some warnings and tidy up

TrabacchinLuigi commented 2 years ago

Should fix #294

TrabacchinLuigi commented 2 years ago

also : is really an uint in unsafe mirror ? can really be that long? i mean, it's still 32bit, and makes more sense, but everywhere else an int32 is used

Liryna commented 2 years ago

Thanks @TrabacchinLuigi for fixing the issue! Very appreciated 😎

Just requested a small change before merge if thats not a problem.

Regarding the int32, anyway for now we are limited but DeviceIoControl max buffer size which is a .... DWORD. We would need to make couple of changes to allow larger sizes

TrabacchinLuigi commented 2 years ago

i've lot of changes right now, if it's not a problem i'll change that on next pull request

TrabacchinLuigi commented 2 years ago

also, i was thinking some attributes are really not needed like marshaling boolean to boolean is the default choice so no need to explicitly specify that

TrabacchinLuigi commented 2 years ago

Dang since i've not made a feture branch i can't do another pull request, git is not my bread and butter, TFS is so much easier

Liryna commented 2 years ago

Yeah when you work on the same branch due to your second commit based on another one that is also a PR, everything ends up in the same PR. That's fine if they are clean commit like yours 👍 Thanks for taking care of the issue your reported!