search

dokan-dev / dokan-dotnet

Dokan DotNet Wrapper
http://dokan-dev.github.io
MIT License
462 stars 116 forks source link

Hardcoded use of date/time and culture in ConsoleLogger #348

Closed Scal-Human closed 11 months ago

Scal-Human commented 11 months ago

Hi,

I wanted to use the ConsoleLogger but is adds a date/time (without the possibility to disable it) in the ambiguous format of the invariant culture (which is hardcoded also). The resulting traces are ambiguous 12 days a month and are not sequential. It would be great to either specify the culture used to format the date and/or to disable the date and add it in the message.

Thanks for the library, anyway. Scal

Liryna commented 11 months ago

The resulting traces are ambiguous 12 days a month and are not sequential.

Invariant format is using US style mm/dd/yyyy.

But I agree that it would be nice to be able to customize the date format.

Scal-Human commented 11 months ago

Hi Liryna, Yes, that is why I was mentioning the fact that the culture is also hardcoded. May I ask you why you closed the issue ?

Liryna commented 11 months ago

The issue was automatically closed because it is fixed by my commit https://github.com/dokan-dev/dokan-dotnet/commit/21f2e5bb69b721dc54583dba8f1bb98542287f48

Scal-Human commented 11 months ago

Ho, super ! Many thanks and happy end of year. (Sorry I missed that) Scal

Liryna commented 11 months ago

No problem! Thanks for the suggestion. Happy end of the year you too!