dokan-dev / dokany

User mode file system library for windows with FUSE Wrapper
http://dokan-dev.github.io
5.2k stars 661 forks source link

Requset support for DOKAN_CHECK_INTERVAL adjustable. #1094

Closed onexzero closed 2 years ago

onexzero commented 2 years ago

Feature request can skip this form. Bug report must complete it. Check List must be 100% match or it will be automatically closed without further discussion. Please remove this line.

Environment

Check List

Description

It would be nice if DOKAN_CHECK_INTERVAL could be set. Currently, it seems to be set to 5 seconds internally, but I wish it was supported so that it can be set through DokanOption. Even if the current DokanOption timeout value is reduced to 1 second, this value is applied to 5 seconds because DOKAN_CHECK_INTERVAL is 5 seconds. To improve responsiveness, it would be nice to be able to set this value by user. This issue is related to the following issue: https://github.com/dokan-dev/dokany/issues/1058#issue-1118119708

Logs

Please attach in separate files: mirror output, library logs and kernel logs. In case of BSOD, please attach minidump or dump analyze output.

Liryna commented 2 years ago

The minimum value that can be enforced is DOKAN_IRP_PENDING_TIMEOUT which a 1/3 of DOKAN_CHECK_INTERVAL https://github.com/dokan-dev/dokany/blob/0a850539a3827d4d32df31dbe48e384c198876ad/sys/dokan.h#L126-L128 https://github.com/dokan-dev/dokany/blob/6bd609be33ae58196e56641095a58a03dd88f682/sys/event.c#L1016-L1026

I see why you made the request because the create being canceled should not have to wait at all to be canceled and can be handled differently https://github.com/dokan-dev/dokany/issues/1058#issuecomment-1133881682

Let me know if that's incorrect and will reopen this.