remove BSF_NOTIMEOUTIFNOTHUNG flag in BroadcastSystemMessage - Githubissues

dokan-dev / dokany

User mode file system library for windows with FUSE Wrapper

http://dokan-dev.github.io

5.27k stars 665 forks source link

remove BSF_NOTIMEOUTIFNOTHUNG flag in BroadcastSystemMessage #958

Closed bailey27 closed 3 years ago

bailey27 commented 3 years ago

Fixes #957.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the existing documentation
[x] My changes generate no new warnings
[ ] I have updated the change log (Add/Change/Fix)
[ ] I have cleaned up the commit history (use rebase and squash)

I think it isn't a significant enough change for updating the change log or even a comment.

I think a rebase/squash isn't needed. I did only one commit.

Changes proposed in this pull request:

Using BSF_NOTIMEOUTIFNOTHUNG in the BroadcastSystemMessage that is done in DokanBroadcastLink after mounting to a drive letter could cause the BroadcastSystemMessage call to block long enough to cause the driver to timeout the fs. This flag is not necessary so it was removed.

-

Liryna commented 3 years ago

Thank you for the quick pull request! Very appreciated.

bailey27 commented 3 years ago

You're welcome!