SYS - Check the return code when deleting the file view

[zqlustc]

When the deletion of the underlying user-mode file system fails, the file view will still be deleted. File still exists after refreshing.

Fixes # 969

Checklist

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the existing documentation
• [x] My changes generate no new warnings
• [ ] I have updated the change log (Add/Change/Fix)
• [ ] I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

• When user delete the file failed, it will not remove the file view in the window.

[Liryna]

@zqlustc The status is always SUCCESS from https://github.com/dokan-dev/dokany/blob/master/dokan/cleanup.c#L37 This PR will not solve the issue you are facing. Could you open an issue and explain your issue there ?

[zqlustc]

Could you open an iss Hi, I am sorry for not making it clear. The dokan and dokanfuse adaptation is modified locally. problem I faced: Now I have a file in the dokan mount point, for example, named test.txt. Right-click to delete the test1 file it will delete test.txt with no prompt, but it maybe failed in the dokan fuse. After I refesh the parent dir of test.txt. It appears again after the directory is refreshed.

[Liryna]

@zqlustc Per microsoft documentation, cleanup cannot fail. If delete must fail, it must be during createfile or set delete that everything need to put in place for the delete to work during cleanup.

[zqlustc]

Hi, Thanks, I get it. Now I have two problems when build the dokan.

• [1] After I execute '.\scripts\build_installer.ps1', it occur the following errors C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\km\wdm.h(18870,32): error C4013: “_DataSynchronizationBarrier” not defined； (source file: access.c) [C:\xxxx\dokany-1.4 .1.1000\dokany-1.4.1.1000\sys\sys.vcxproj] C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\km\wdm.h(18870,32): error C4013: “_DataSynchronizationBarrier”not deifned；(source file: close.c) [C:\xxxx\dokany-1.4. 1.1000\dokany-1.4.1.1000\sys\sys.vcxproj] C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\km\wdm.h(19237,22): error C4013: “_MoveFromCoprocessor”not defiend; (source file: access.c) [C:\xxxx\dokany-1.4.1.1000

• [2] Can we add a parameter to build x64 only with '.\scripts\build_installer.ps1'. ARM,ARM64,... is useless for me.

[Liryna]

Glad you have been able to find a way to get around your cleanup issue.

[zqlustc]

Hi, Sorry to send email to you for help several times. You Are very friendly and outstanding. Thanks very much.

Now I have a problem.  Could we build the x64 setup only with build_installer.ps1? In other word, could I add some parameters to build the x64 setup, not all arch? Thanks.

---Original--- From: "Liryna"<notifications@github.com> Date: Mon, Feb 8, 2021 15:50 PM To: "dokan-dev/dokany"<dokany@noreply.github.com>; Cc: "张奇龙"<984811670@qq.com>;"Mention"<mention@noreply.github.com>; Subject: Re: [dokan-dev/dokany] SYS - Check the return code when deleting the file view (#970)

Closed #970.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[zqlustc]

Hi, I have find the method to build x64 setup only. Thanks.

---Original--- From: "Liryna"<notifications@github.com> Date: Mon, Feb 8, 2021 15:50 PM To: "dokan-dev/dokany"<dokany@noreply.github.com>; Cc: "张奇龙"<984811670@qq.com>;"Mention"<mention@noreply.github.com>; Subject: Re: [dokan-dev/dokany] SYS - Check the return code when deleting the file view (#970)

Closed #970.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.