search

dokar3 / quickjs-kt

A QuickJS binding for idiomatic Kotlin, with Async/DSL/ES Modules support.
Apache License 2.0
49 stars 4 forks source link

build script lacks execution permission #100

Closed TelephoneTan closed 4 months ago

TelephoneTan commented 5 months ago

./quickjs/native/cmake/zig-ar.sh ./quickjs/native/cmake/zig-ranlib.sh

dokar3 commented 4 months ago

You might need to grant execute permission manually, see: https://github.com/dokar3/quickjs-kt/blob/f748724d8d25c282d19e4d455372144def92f80c/.github/workflows/build.yaml#L56

TelephoneTan commented 4 months ago

Why not commit the file mode into git?

Git can record file mode.

dokar3 commented 4 months ago

Didn't even know this existed. As a Windows user, it feels somewhat illegal.

TelephoneTan commented 4 months ago

After chmod, git status will show that the files have been modified.

dokar3 commented 4 months ago

Good, I just searched it, this requires configs core.filemode true, will try on WSL later if it works.