doki-theme / doki-theme-hyper

Cute anime character themes for Hyper.js.
MIT License
92 stars 2 forks source link

[Fix] .hyper.js fontFamily settings not working. #37

Closed VergeDX closed 3 years ago

VergeDX commented 3 years ago

I noticed that "fontFamily" section of config file .hyper.js not working, so I search for these issues. Here is what I found: https://github.com/vercel/hyper/issues/3343#issuecomment-451235240. Then I realize these issues may be caused by the theme. I check out the code of https://github.com/defringe/verminal and seems we shouldn't define the section "fontFamily" in the file "src/syntax.ts". This is what theme verminal do: https://github.com/defringe/verminal/blob/master/index.js#L62

VergeDX commented 3 years ago

@Unthrottled Also, I suggest apply css .tabs_title { color: #000000 } (Title color: black) in Light theme, apply .tabs_title { color: #FFFFFF } (Title color white) in Dark theme.

Unthrottled commented 3 years ago

Also, I suggest apply css .tabs_title { color: #000000 } (Title color: black) in Light theme, apply .tabs_title { color: #FFFFFF } (Title color white) in Dark theme.

Any particular reason (a particular theme)? I went through all of the themes and they all appear to be using the foregroundColor as defined in the master definition.

Unthrottled commented 3 years ago

Changes have been published, thanks again!

VergeDX commented 3 years ago

@Unthrottled Well because my Hyper terminal title font color is always white, like the screenshot below. So I have no choice to add CSS .tabs_title { color: #000000 }... image This is strange because I noticed your screenshot in https://github.com/doki-theme/doki-theme-hyper/issues/30, your hyper terminal title color has no such issue... So I think there are issues with plugins or macOS, can you share your plugins list...? Thanks.

Unthrottled commented 3 years ago

Ah, I saw the issue as well. I was on v8.0.0 after taking the v8.1.1 update and restarting hyper, it went to this

Screen Shot 2021-03-29 at 5 21 02 PM

I am also using the canary version

Screen Shot 2021-03-29 at 5 21 27 PM

Let me know if upgrading and restarting works for you. @VergeDX

VergeDX commented 3 years ago

Oh yes, I noticed it becomes normal XD. Thanks for patients <3