search

doki-theme / doki-theme-icons-jetbrains

A nice mix of cool and cute icons for your JetBrains IDEs!
MIT License
58 stars 3 forks source link

[Bug]: Python file icon remains default with the plugin #117

Closed dolphinbird closed 3 months ago

dolphinbird commented 4 months ago

Your Environment

PyCharm 2024.1 (Community Edition) Build #PY-241.14494.241, built on March 28, 2024 Licensed to Zi Subscription is active until April 19, 2025. For educational use only. Runtime version: 17.0.10+8-b1207.12 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Windows 11.0 GC: G1 Young Generation, G1 Old Generation Memory: 2048M Cores: 12 Registry:

Non-Bundled Plugins:

How to reproduce.

Step One: Open Project with Step Two: Create Python file (.py) The python file keeps its default colors

Screenshot in which the python file's icon remains unchanged while the rest of the UI has the cute doki icons

What is expected?

Previously, the python logo would change and it matched with the rest of the icons. After this update, it no longer does this and keeps the default icon. How it looks like loaded up on ver. 2023.3.5:

Screenshot with the expected python icon
Eta0 commented 3 months ago

It looks like a potentially similar issue came up for the catppuccin theme, related to this JetBrains bug (PY-44417), and was addressed in catppuccin/jetbrains-icons#26 by adding and registering a ProjectViewNodeDecorator, so maybe something similar could be used here. Although probably for a few more files than just ones named .py, like .pyx as well.