search

doki-theme / doki-theme-jetbrains

Cute anime character themes for your JetBrains IDEs.
MIT License
645 stars 38 forks source link

Python file icon #329

Closed SansPapyrus683 closed 3 years ago

SansPapyrus683 commented 3 years ago

(not really sure if this is a bug)

Describe the bug The Atom .py file icon doesn't show in the file explorer.

To Reproduce

  1. Install the plugin
  2. Done.

Expected Behavior I thought that the Atom icon would display in the file explorer as well.

Environment image OS: Windows 10 Plugin version: Most recent as of 2/5/2021

Screenshots Right now this is what shows: image Strangely, in the tabs, the Atom python icon shows just fine: image

Unthrottled commented 3 years ago

Hey! So I have a quick work around at the moment (I think).

Download doki-theme-jetbrains-12.5.3.zip and install it manually using Preferences > Plugins > ⚙️ > Install plugin from disk...

That should work. JetBrains is changing how they load classpath resources, so something is amiss when I built it with the latest platform SDK.

BTW, it's bugging me that i cant tell if you are using Ishtar's or Darkness's theme :sweat_smile:

Edit: It may not work, I think I tested it without the python plugin installed, it acts wonky when the python plugin is installed....Stay tuned, worse case you can just revert back to https://github.com/doki-theme/doki-theme-jetbrains/releases/tag/v12.4.1

Edit2: Did this ever even work in the first place?

SansPapyrus683 commented 3 years ago

Uh, I think ever since I installed it the icon doesn't seem to show. (also this is darkness's theme)

Unthrottled commented 3 years ago

@SansPapyrus683 Thanks for the update! If you want, you could probably install https://github.com/mallowigi/a-file-icon-idea . It is maintained by somebody who actually uses that feature, so it might not have this issue :smile:

Just to manage your expectations, I'll see what I want to do with this issue after I finish adding more themes https://github.com/doki-theme/doki-master-theme/milestone/2 (as if I don't already have enough). So I'll probably get around to this sometime when I am also ready to work on #324 . Thanks for your patience and understanding! (Also thanks solving the mystery theme for me too! I thought it might be Darkness, but wasn't sure :)

SansPapyrus683 commented 3 years ago

I think this issue got fixed with the newest release, so I'll close it.

Unthrottled commented 3 years ago

:thinking: It still an issue but it is not an issue with Material Atom Icons.

Doki File Icons image

Material Atom Icons image

When I work on the new set of themes this month, I'll see if I cant fix this feature (Removing it is also a fix :smile: )