doki-theme / doki-theme-jetbrains

Cute anime character themes for your JetBrains IDEs.
MIT License
647 stars 40 forks source link

Stickers showing pixelated #465

Closed leo283 closed 2 years ago

leo283 commented 3 years ago

Describe the bug

When you set up any sticker it looks pixelated

To Reproduce

  1. It's appearing on a laptop acer nitro 5, it's got a fullhd monitor

Expected Behavior

The sticker should look like the vscode one, with no problems

Environment

Screenshots

image

Unthrottled commented 3 years ago

Please go to IntelliJ IDEA -> About IntelliJ IDEA (Mac) or Help -> About IntelliJ IDEA (Windows) and copy the infos to the clipboard and paste it here.

It should contain:

Unthrottled commented 3 years ago

Also, can you tell me if Hayase Nagatoro's sticker is also pixelated?

Nagatoro

leo283 commented 3 years ago

Please go to IntelliJ IDEA -> About IntelliJ IDEA (Mac) or Help -> About IntelliJ IDEA (Windows) and copy the infos to the clipboard and paste it here.

It should contain:

  • OS (Windows, Linux, Mac)
  • IntelliJ Product + version (IDEA, RubyMine...)
  • JDK Information
  • Plugin version
  • If needed a list of enabled plugins - This is what shows up on the about window image The OS version is windows 11 21h2

This is the plugin version image

leo283 commented 3 years ago

Also, can you tell me if Hayase Nagatoro's sticker is also pixelated?

Nagatoro

Hayase nagatoro's theme is not showing on the options menu image

Unthrottled commented 3 years ago

Sorry for not including the prefix image

leo283 commented 3 years ago

Well, it also looks pixelated image

Unthrottled commented 3 years ago

Darn, I thought it might have had something to do with the pixel resolution of the image, maybe. Nagatoro has a higher resolution than Rin at the moment.

I'll look into reproducing the issue.

leo283 commented 2 years ago

Hey man, did you find any solutions?

Unthrottled commented 2 years ago

Hey, I haven't been able to replicate the issue. Been putting off installing Windows 11 until I get a new hard drive, sorry!

Does the issue still happen when you set a custom sticker?

leo283 commented 2 years ago

Hey, i just found out somenthing that might be the cause When i change the scale of my laptop from 125% to 100% the sticker looks good. Maybe you can try to reproduce the issue by changing the screen scaling to 125% image This is how it looks on 100%

Unthrottled commented 2 years ago

image

Yup that did it 😭

Thanks! I'll look into getting that fixed.

leo283 commented 2 years ago

Thanks! And by the way, merry Xmas! πŸŽ‰

Unthrottled commented 2 years ago

Happy to help.

Merry xmas to you as well! I'm hoping πŸŽ… brought me a bug fix, I've been a good open source maintainer this yearπŸ˜‚ .

Unthrottled commented 2 years ago

Alright, think I got the issue fixed. You can follow the manual installation instructions to download the version with the fix. (edit: you'll be able to do that after this job finishes https://github.com/doki-theme/doki-theme-jetbrains/actions/runs/1622323061)

Here is a larger Rin sticker if you wanted to build your own sized custom sticker.

shima_rin_dark

leo283 commented 2 years ago

Thank you soo much! :)

Unthrottled commented 2 years ago

Just as an update, future versions of the plugin will contain a Ignore Scaling setting that replaces the functionality I added to address this issue. You'll have to enable that setting to get around the pixelated image.