search

doki-theme / doki-theme-jetbrains

Cute anime character themes for your JetBrains IDEs.
MIT License
647 stars 40 forks source link

[FEATURE] Add 'Reset' button for sticker positioning #481

Closed Dragon-0609 closed 2 years ago

Dragon-0609 commented 2 years ago

Is your feature request related to a problem? Please describe. Some minutes ago I worked on Yuki Theme's sticker positioning. I added positioning, but didn't know what would happen when a user disables Allow positioning. Either the sticker stays on the default position or it stays on the new position. So, I looked in Doki Theme's settings. There was no Reset button for that. I changed position of a sticker, after that disabled Allow positioning. I got answer for my question. But, I moved the sticker, so now I can't put it on the default position. So, could you add Reset button for that?

Describe the solution you'd like After pressing Reset button, the sticker will stay on it's default position

Unthrottled commented 2 years ago

As of v22.3.0 there are 3 places where a sticker could be:

  1. The last place that the user dragged the sticker to.
  2. The user saved relative position in the window.
  3. The plugin default relative position in the window.

Reset Sticker Margin returns the sticker to the position described in 3.

What you are describing is a feature that allows users to have the sticker be re-placed backed to the saved position (if there is a saved position) or the default position, correct?

Example of reseting sticker margin:

https://user-images.githubusercontent.com/15972415/148624439-2201932f-b6f0-453a-aaeb-513d65004343.mp4

Dragon-0609 commented 2 years ago

Reset Sticker Margin

My Doki Theme's version isn't the latest. So I may have missed this version.

Dragon-0609 commented 2 years ago

Added the ability to double-click movable stickers to save their relative position in the window.

If the user doesn't double-click, will stickers return to the last saved position on next start of IDE?

Unthrottled commented 2 years ago

If the user doesn't double-click, will stickers return to the last saved position on next start of IDE?

Correct, or if they open another project the sticker in that window will be in the default position.

I was thinking that you were suggesting a way for stickers to return back to the saved position, after it was previously moved (but not saved). That is still a valid feature. Reset Sticker Margin restores the location to the default position and not the saved position.