doki-theme / doki-theme-jetbrains

Cute anime character themes for your JetBrains IDEs.
MIT License
647 stars 41 forks source link

[BUG] Small Duplicates of sticker in Dimension Cap when increasing the size from small to big #522

Closed Dragon-0609 closed 2 years ago

Dragon-0609 commented 2 years ago

Describe the bug I wanted to add Sticker Dimension Cap to my plugin. So, I have tested it in The Doki Theme. I noticed that small sticker stays over the size increased sticker. See screenshots for better understanding.

To Reproduce

  1. Enable Primary Sticker Dimension Capping
  2. Set Width & Height to 70, save
  3. Set Width & Height to 140, save
  4. Set Width & Height to 300, save

Expected Behavior To be sized without small duplicates.

Environment

JetBrains Rider 2021.3.3
Build #RD-213.6775.4, built on January 26, 2022
Runtime version: 11.0.13+7-b1751.25 amd64
VM: Dynamic Code Evolution 64-Bit Server VM by JetBrains s.r.o.
Windows 10
.NET Framework 4.0.30319.42000
GC: G1 Young Generation, G1 Old Generation
Registry:
    ide.intellij.laf.enable.animation=true
    rdclient.asyncActions=false
    indexing.enable.entity.provider.based.indexing=false
    ide.new.project.model.index.case.sensitivity=true

Non-Bundled Plugins:
    tanvd.grazi (213.6461.19)
    io.unthrottled.theme.randomizer (0.2.1)
    io.acari.normandy.progress.bar (1.9.11)
    io.acari.DDLCTheme (78.2-1.1.1)
    io.unthrottled.amii (0.14.0)
    io.unthrottled.amii.rider (0.4.0)
    String Manipulation (9.4.0)
    izhangzhihao.rainbow.brackets (6.21)
    com.microsoft.vso.idea (1.161.1)

Screenshots 70px: bandicam 2022-05-27 13-44-59-039

140px: bandicam 2022-05-27 13-45-09-774

300px: bandicam 2022-05-27 13-45-21-171

Unthrottled commented 2 years ago

I'll add this to my todo list once I have completed what I am currently working on, thanks!

Unthrottled commented 2 years ago

Hmm, the issue isn't reproducible on MacOS

IntelliJ IDEA 2022.2 EAP (Ultimate Edition)
Build #IU-222.2680.4, built on May 25, 2022
Licensed to IntelliJ IDEA EAP user: Alex Simons
Expiration date: June 24, 2022
Runtime version: 17.0.3+7-b463.3 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.4
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 10
Non-Bundled Plugins:
    io.acari.DDLCTheme (78.2-1.2.0)

Kotlin: 222-1.6.21-release-357-IJ2680.4

I'll give windows machine a try (and probably try it on Rider as well)

Unthrottled commented 2 years ago

Changed my mind, I can reproduce it on MacOS. The issue only happens after I've switched to another theme and then attempt constrain the dimensions.

Edit:

But only on

IntelliJ IDEA 2021.3 (Ultimate Edition)
Build #IU-213.5744.223, built on November 27, 2021
Licensed to Alex Simons
You have a perpetual fallback license for this version.
Subscription is active until February 20, 2023.
Runtime version: 11.0.13+7-b1751.19 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.4
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 10
Non-Bundled Plugins:
    io.acari.DDLCTheme (78.2-1.2.0)

Kotlin: 213-1.5.10-release-949-IJ5744.223

2022.2 works as expected 😒

Unthrottled commented 2 years ago

I wasn't reliably able to reliably reproduce the issue, but I think I have fixed the symptom. So once you update to the new version (when available) and it is still broken, please follow up on this issue, and I'll look into it again.

Dragon-0609 commented 2 years ago

OK