doki-theme / doki-theme-visualstudio

Cute anime character themes for Visual Studio.
https://marketplace.visualstudio.com/items?itemName=unthrottled.dokithemevisualstudio
MIT License
126 stars 9 forks source link

Text on non-code editor windows with overwritten background doesn't respect Dark/Light setting #39

Closed neneeen closed 2 years ago

neneeen commented 2 years ago

I have https://marketplace.visualstudio.com/items?itemName=MichaelKissBG8.Supercharger22 installed, which add a code map on the left of the code editor https://supercharger.tools/index.html#sectionCodeMAP

With dark themes, on initial load, the code map looks like this image, the background doesn't extend to the code map, which is not too nice, but at least usable, and much better than after a while when the code map looks like this image

The text seems to default to black. Weirdly enough this happens even with themes not provided by Doki Theme, such as the default Black image

With doki theme disabled, the text on the code map is correctly displayed image

If there's no way to tell the code map to respect the dark light setting because it's generated by another extension, is there a way to at least disable the background overwriting altogether for non-code editor windows?

Unthrottled commented 2 years ago

Hi!

Can you answer these questions for me, please?

I'll look into trying to reproduce the issue.

neneeen commented 2 years ago

VS is 17.0.4 with rich client and graphic acceleration enabled, Doki is 3.0.0, Supercharger is 1.12.0.1600, Windows 10 21H2 19044.1415

Unthrottled commented 2 years ago

Thank you for providing the supporting information!

I am having trouble replicating the text becoming black/background image drawing on the background.

Is there a way you can reproduce it? I know you said that: than after a while when the code map looks like this, does it happen after you do something or is it just after time passes?

neneeen commented 2 years ago

The time varies, sometimes it just happens by itself almost immediately, less than 15 seconds, sometimes it seems to take a while, maybe 1-2 minutes. Doesn't seem to care whether I'm typing in the window or not. Does closing and opening the window still gives you no image drawing in the background? Perhaps Supercharger is configured differently on a new install, mine carries the previous profile, I do try resetting the Supercharger profile, but the problem persists.

Steps to reproduce, with all other VS extensions disabled except Supercharger & Doki :

  1. Create a new C# .NET 6 Console project
  2. Add a new method to test the code map image

I do find a workaround just now, it turns out in the Supercharger options, on the CodeMAP - Visual - Theme, there are radio buttons for

In my install, the Mimic option is selected, changing it to Specific Light/Dark disable the background image on the code map, and the text does follow the Specific setting. image

If your install is in the Mimic option, I guess it's the Supercharger's fault in detecting whether the current theme is dark/light. Either way, the problem is with Supercharger. Thank you for the support!