doki-theme / doki-theme-visualstudio

Cute anime character themes for Visual Studio.
https://marketplace.visualstudio.com/items?itemName=unthrottled.dokithemevisualstudio
MIT License
126 stars 9 forks source link

Background color in SQL editor doesn't match theme #45

Closed beleester closed 2 years ago

beleester commented 2 years ago

If you open a SQL file in Visual Studio, the editor has a black background, which makes it unreadable with light themes. Example with Satsuki Light theme:

image

Unthrottled commented 2 years ago

Thanks for taking the time to report the issue, it looks like it might be related to #21 . Are SQL files the only one's currently impacted by this issue?

I'll have some time in the near future to look into the fix, thanks!

Unthrottled commented 2 years ago

Hey! I am not able to replicate the the issue

image

Are you using an extension that does stuff with SQL files?

beleester commented 2 years ago

Apparently I have "SQL Server Data Tools - SQL Editor" installed. That looks relevant.

I can't find where its colors get configured in the Options menu.

Unthrottled commented 2 years ago

Got it, thank you!

I can't find where its colors get configured in the Options menu

This is most likely a side effect of how the wallpaper gets added to the editor background.

Unthrottled commented 2 years ago

Hey! I think I've got the issue fixed. I still wasn't able to get the same view you showed in your screen shot. If you could upgrade the extension to 78.1.2, and see if it fixed the issue.

If it didn't get fixed, then could you give me some details as to how to open that view? I don't really use Visual Studio, so I'm not very familiar with its functionality. Thanks!

beleester commented 2 years ago

This appears to have fixed it! Thank you.