doki-theme / doki-theme-vscode

Cute anime character themes for VS-Code.
https://marketplace.visualstudio.com/items?itemName=unthrottled.doki-theme
MIT License
894 stars 50 forks source link

Wallpaper not showing in main screen #131

Open JowMK opened 2 years ago

JowMK commented 2 years ago

Describe the bug Wallpaper does not show in the mainscreen backgound (where the vscode logo is, also where the wallpaper should look without the transparency filter), but still shows when opening a file or in the console.

To Reproduce Firstly I can't asume its reproducible, I can't revert vscode to fresh install, so problem persists even after deleting settings.json and so, so this steps its all I did:

  1. Install theme
  2. chose backgound
  3. jump into ssh sesion
  4. install extension and wallpaper there too
  5. Work and turn off
  6. Next morning vscode (no ssh) not showing backgound on main page (where watermark)

Expected Behavior The wallpaer shoul show without the transparency filter (not dimed down) in the main screen (where the vscode logo watermark)

Environment Version: 1.64.2 (user setup) Commit: f80445acd5a3dadef24aa209168452a3d97cc326 Date: 2022-02-09T22:02:28.252Z Electron: 13.5.2 Chromium: 91.0.4472.164 Node.js: 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0.19042

Doki theme version --> v74.1.0

Screenshots image image

Not related to a specific wallpaper: image

Note

If needed, I can provide any file

Unthrottled commented 2 years ago

Thank you for providing all the supporting information!

Had a question.

  1. jump into ssh sesion

I'm assuming this is connecting in to a VS Code server?

Does this issue thread help?

If not, I'll ask some more question on what exactly it is you are doing.

Edit:

, I can't revert vscode to fresh install,

The Remove Sticker/Background command will revert all changes to VSCode, if that helps.

JowMK commented 2 years ago

I'm assuming this is connecting in to a VS Code server?

I'm connecting to a VM via ssh extension, I don't really know if that counts as a VS Code server

ssh problem this is what it looks like. The Doki Theme extension is no longer installed in the VM, it must have disappeared after I tried to "factory reset" VS Code

The Remove Sticker/Background command will revert all changes to VSCode, if that helps.

Yeah I'm conscious of that, and that works on removing the background. What I meant by that, is that even after deleting the "settings.json" file, there was still some configurations lingering after I reinstalled VS Code and I don't know where the files are at.

Unthrottled commented 2 years ago

I'm connecting to a VM via ssh extension, I don't really know if that counts as a VS Code server

Got it, it looks like that machine has GitPod. So you might be connecting to a remote VS Code. I think it works the same way attaching to a WSL session works. Where your local VS Code (on your windows machine) acts as a front end to a VS Code server running on, like this.

image

I think you only need to install the Assets when you are not connected (step 4), unless that prevents the asset from showing when connected to a session. If that is the case, then this issue might be related to #121 .

JowMK commented 2 years ago

it looks like that machine has GitPod

indeed it has Gitpod, but I haven't stablished a gitpod connection since long before I installed the Doki theme.

I think it works the same way attaching to a WSL session works.

Never used it but tried and seems basically the same. Sadly it doesn't work there too

I think you only need to install the Assets when you are not connected

Yea, is there a way to brute force the wallpaper install, or at least that part. I know the extension is in charge to edit the corresponding files for the wallpaper to appear, but maybe it's encountering some sort of permission error (even when they shouldn't) or the file is corrupted. Also where I can find that step 4 you are referring to?

image

Also checked the gitpod issue you named, but basically all I've ever done in gitpod is edit a README.md file, so it's never been modified or used with vscode (also flashbang alert)

Unthrottled commented 2 years ago

Also where I can find that step 4 you are referring to?

Sorry, was referring to your reproduction steps:

To Reproduce Firstly I can't asume its reproducible, I can't revert vscode to fresh install, so problem persists even after deleting settings.json and so, so this steps its all I did:

  1. Install theme
  2. chose backgound
  3. jump into ssh sesion
  4. install extension and wallpaper there too
  5. Work and turn off
  6. Next morning vscode (no ssh) not showing backgound on main page (where watermark)

I guess my issue is, I don't know how to do/or what is being done step 3, what machine are you SSH'ing into? Is it literally just a plain box, or are you establishing a remote connection to a VS Code server (see remote extension host in the doc referenced) where your VSCode is a client for the remote host being SSH'ed into?

JowMK commented 2 years ago

Sorry, was referring to your reproduction steps

Oh, ok

what machine are you SSH'ing into?

It's a Linux VM from my college host, I do not know anything else regarding it's structure of things of the sort, but I do know its a large server running Virtualization software for a large number or users. Never had any problem using any VM since it basically a Ubuntu system without gui.

Is it literally just a plain box, or are you establishing a remote connection to a VS Code server

After seeing the image here, I can tell the ssh connection is to a VSCode Server (at least some kind)

Unthrottled commented 2 years ago

Got it, that's what I thought. Thanks for the clarifying information. I might have some time to investigate it this weekend. However, it might be like you said, the extension might not be able to write the CSS file on the remote server to add the assets (permissions errors or something).

Unthrottled commented 2 years ago

I am not able to replicate the issue.

When I ssh into my remote machine, the background image & wallpaper, still stay there. So I didn't need to install the background image/wallpaper again.

After I get done, and close code and open it back up, the background image and wallpaper remain.

Here is me fumbling through it:

https://user-images.githubusercontent.com/15972415/158207465-69305e1f-6209-4fae-9fd5-b44e35246f74.mp4

Am I doing something wrong?

JowMK commented 2 years ago

First of all, sorry for the late response. Regarding your findings:

I am not able to replicate the issue.

Am I doing something wrong?

Not that I can see. I'm beginning to think this could have been one of (too many) VScode bugs, because the thing was, back then when I did that ssh connection, it did not kept the background as yours did, so if it isn't replicable that's a good thing in general. I think I won't keep pestering you with this anymore but I want to ask you a final question:

Is it possible for me to manually edit the file responsible to showing the wallpaper (that mentioned CSS file) so I manually set the background to the extension asset in question?

I do not know if it is possible, mostly because I do not know how VScode manages extensions in the first place, but if I some how can access the background asset and hardcode it into the file, it should work (?)

Unthrottled commented 2 years ago

No worries, I just want to make sure you have a good user experience 😃

If you want to manually change the CSS, feel free to look at the issue thread here https://github.com/doki-theme/doki-theme-vscode/issues/61 that should give you an idea of where the files are.

You can find the lastest CSS here https://github.com/doki-theme/doki-theme-vscode/blob/91c4647437b707ed7272316122698f973e555c90/src/StickerService.ts#L28

Just a side note, you'll need to use a base 64 data url for your image, because VSCode prevents external files loading in the browser.