doki-theme / doki-theme-vscode

Cute anime character themes for VS-Code.
https://marketplace.visualstudio.com/items?itemName=unthrottled.doki-theme
MIT License
894 stars 50 forks source link

Wallpaper and Sticker not working #61

Closed master117 closed 3 years ago

master117 commented 3 years ago

Describe the bug Wallpaper and Sticker not working.

I switch VSCode to admin then download the extension, switch to Rem Theme (works). Then I add sticker and background via ctrl+shift+p menu and restart vscode. Neither Wallpaper nor Sticker show up. Extension works in IntelliJ.

Environment Windows, VSCode 1.55.2, Doki Theme v11.1.1

image

Unthrottled commented 3 years ago

https://user-images.githubusercontent.com/15972415/114945530-1f31fd80-9e0f-11eb-89d9-c8753d7dcf58.mp4

Just to make sure that I am on the same page. You were able to run all of the steps above (minus the checksum) and all of the notifications showed up saying it worked?


If that is the case then, I'll ask you to inspect the VS Code workbench.desktop.main.css file.

Here is where mine is, if that helps

C:\Users\birdm.DESKTOP-FO92PV5\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench

image

At the bottom of the the css file, you should see the background/sticker styles.

image

You'll probably want to check to see if those files exist. If not, you're free to change them to whatever you want :)

These are the defaults downloaded by the plugin:

Glass Pane Wallpaper https://doki.assets.unthrottled.io/backgrounds/wallpapers/transparent/rem.png

Empty Editor Background https://doki.assets.unthrottled.io/backgrounds/wallpapers/rem.png

Sticker https://doki.assets.unthrottled.io/stickers/vscode/reZero/rem/rem.png


I think it may be an issue of the plugin not being able to save the assets in the directory specified by the CSS file.

Let me know if that helps, you need more info, or you solved the problem.

Edit:

This is my vscode image

master117 commented 3 years ago

Ok the CSS definitely got applied.

image

But the images are missing from the specified directory.

image

I think it may be an issue of the plugin not being able to save the assets in the directory specified by the CSS file.

Probably, yes.

What is the easiest way to get the images manually? Extract them from the .md files?

Thanks for linking the files.

never-unsealed commented 3 years ago

Same issue for me. Did not find a fix so far.

master117 commented 3 years ago

Same issue for me. Did not find a fix so far.

Put the Images into the folder they should be in as indicated by the css.

Unthrottled commented 3 years ago

@smokeSH Are you also on windows 10?

never-unsealed commented 3 years ago

Thanks for the help @master117

Yes, I'm also on Windows 10

Clxmmm commented 3 years ago

I've almost the same problem expect for non-existing files. image I'm on W10, my VSCode is up to date. Installed this extension on my two computers and same issue on them.

Any idea? Thanks

master117 commented 3 years ago

I've almost the same problem expect for non-existing files. image I'm on W10, my VSCode is up to date. Installed this extension on my two computers and same issue on them.

Any idea? Thanks

That makes it a very different issue. See if the css files are where they are supposed to be and reload your VS.

Unthrottled commented 3 years ago

@master117 I am trying to reproduce this issue, and I can't. Do you have this issue if you attempt to install a sticker/wallpaper of another girl?

If so, could you take a peek at the console developer tools, please

image

I have some code that doesn't attempt to download the asset if it checked already that day, and am wondering if that is being a jerk. I already have code that creates the directories if they don't exists, so it can put the assets where they need to be.

master117 commented 3 years ago

@Unthrottled Sure

grafik

It seems like there is some problem in that script. But I think I figured out what the problem is.

grafik

I was able to download a new wallpaper after leaving my companies vpn. So this is most likely a proxy issue. I just didn't realize because the first time I tried that I already had tried once for that wallpaper within that day. So the optimization got me.

Unthrottled commented 3 years ago

@master117 Great! That's what I thought it might have been, that's what I get for trying to be clever.

I'll have a fix out that will always attempt to download or update the asset when a user attempts to install a new/same asset.

Thanks for the insights and helping out the others having issues!

master117 commented 3 years ago

Maybe an error message for failed downloads would be good. I can test it if you want.

Clxmmm commented 3 years ago

I've almost the same problem expect for non-existing files. image I'm on W10, my VSCode is up to date. Installed this extension on my two computers and same issue on them. Any idea? Thanks

That makes it a very different issue. See if the css files are where they are supposed to be and reload your VS.

Okay, just checked on my main computer. The workbench css file is in my HDD and the wallpapers are in my SSD. I really don't know if it change anything. In the css file the images are at the right place.

Unthrottled commented 3 years ago

@Clxmmm Did you check the contents of the CSS? At the bottom of the file you should see some of relevant css.

Example

Clxmmm commented 3 years ago

@Unthrottled Yep, i've exactly the same css except for the bg-pos which is centered. Images redirects at right url etc...

master117 commented 3 years ago

Do you see the css getting applied in the vsc developer tools inspector? @Clxmmm

Clxmmm commented 3 years ago

Do you see the css getting applied in the vsc developer tools inspector? @Clxmmm

image Yep right here in first pos of styles And i've checked, there is the sticker and wallpaper styles in the css file

Unthrottled commented 3 years ago

@Clxmmm and there is nothing in the developer tools console that says that local content is blocked?

Have you tried changing the url in the css to point at https://doki.assets.unthrottled.io/backgrounds/wallpapers/transparent/rem.png and reloading VS code?

Clxmmm commented 3 years ago

image Okay so just tried with the web link it's working (see on screen) Now checked in the devtool if css is working so I checked in the abyss of VSC CSS for finding the [id="workbench.parts.editor"] .split-view-view .editor-container .editor-instance>.monaco-editor .overflow-guard>.monaco-scrollable-element::before, line. Result : no before created in monaco-scrollable-element class... image

Unthrottled commented 3 years ago

Now checked in the devtool if css is working so I checked in the abyss of VSC CSS for finding the [id="workbench.parts.editor"] .split-view-view .editor-container .editor-instance>.monaco-editor .overflow-guard>.monaco-scrollable-element::before, line. Result : no before created in monaco-scrollable-element class...

I am a bit confused what you where trying to do. What where you trying to verify the style was being applied? There are a ton of styles that support the glass pane wallpaper feature

See here https://github.com/doki-theme/doki-theme-vscode/blob/d03dc37aa08f884b0b3fc414a385e5efa8dd1631/src/StickerService.ts#L26

Okay so just tried with the web link it's working (see on screen)

Cool! Not cool if you want to code offline though... I wonder why local content is not working. I think that is the issue that is preventing things from showing up @Clxmmm

Unthrottled commented 3 years ago

@master117 I've got a PR set up here https://github.com/doki-theme/doki-theme-vscode/pull/63 if you wanted to test it out (I've attached it in the description). I'll merge it tomorrow when I get the chance. Thanks!

Clxmmm commented 3 years ago

Now checked in the devtool if css is working so I checked in the abyss of VSC CSS for finding the [id="workbench.parts.editor"] .split-view-view .editor-container .editor-instance>.monaco-editor .overflow-guard>.monaco-scrollable-element::before, line. Result : no before created in monaco-scrollable-element class...

I am a bit confused what you where trying to do. What where you trying to verify the style was being applied? There are a ton of styles that support the glass pane wallpaper feature

See here

https://github.com/doki-theme/doki-theme-vscode/blob/d03dc37aa08f884b0b3fc414a385e5efa8dd1631/src/StickerService.ts#L26

Yeah yeah I was a bit motivated to find it and it didn't really worked...

Okay so just tried with the web link it's working (see on screen)

Cool! Not cool if you want to code offline though... I wonder why local content is not working. I think that is the issue that is preventing things from showing up

I've maybe an idea, for my main computer only, my VS Code can't update, maybe it's related. image If I don't find solution, I will use the direct link, I almost never code offline so it doesn't matter but it's sad to have to change it in the css.. Maybe PR will help i'll try tomorrow ! Thanks !

Clxmmm commented 3 years ago

I think I've found the problem on my secondary computer ! It might be because in the path in css some char are not allowed or something like that My appdata user is " Clem' " maybe the apostrophe is the big problem of everything ( and so i don't know if you can solve )

Unthrottled commented 3 years ago

@Clxmmm Could you try URL encoding the string (eg: Clem%27)? If that works I can add logic in the plugin to url encode the local file path.

Clxmmm commented 3 years ago

Yeah it's working ! It would be nice thanks !

Ghostel23 commented 1 month ago

I'm having trouble getting the wallpaper to show, even though the theme shows, I'm not able to get it to work. The error pops up when I try to download but the error says, “The command could not be found” and I really don't know what to do. The same happens with the stickers image

Katyusha47 commented 1 week ago

Screenshot 2024-10-22 083642

i have an issue. CSS doesnt appear