Closed Unthrottled closed 2 years ago
PERMISSIONS.md file which explains why each permission in the manifest is necessary
Does that file do anything or is that just for anybody reviewing the product?
I also moved search to an optional permission, is there any other things that should be optional?
Does that file do anything or is that just for anybody reviewing the product?
The latter
is there any other things that should be optional?
The browserSettings
permission can also be optional, However it might be a bit tricky(?.) Out of all the Theme Settings options, all
, light
, & dark
does not rely on system settings instead they use the browser settings (which is the default if the browserSettings permission was not at all added to this extension in the first place.).
So it would be ideal to place the activate this permission only if druther
or device
was chosen.
I added browserSetting as an optional permission to be requested only when the user selects the druthers
or device
option. I also learned the hard way, that you can only request permissions in a eventHandler.
I also learned the hard way, that you can only request permissions in a eventHandler.
You've just experience the beauty of an event-driven programming language.
Since it is a small code change, there was an issue when the user selects an option in the General category. The Options Page would refresh, which, in turn, navigate the user away from the Options Page. This is fine if configuring one option, however multiple configurations would require the user to navigate back to the Options Page continuously.
Edit: forgot to mention here, I've already resolve the issue.
Since it is a small code change, there was an issue when the user selects an option in the General category
Cool! I tested it out, works as advertised.
This has been a long running PR and I have lost track of the outstanding issues, is the last thread that needs to be addressed? https://github.com/doki-theme/doki-theme-web/pull/86#discussion_r778472225
@Unthrottled Yes, in accordance to Opt-In Firefox Features.
Note: https://github.com/doki-theme/doki-theme-web/pull/86#discussion_r778689670
Alright, I think everything is squared away now.
What should be done with the suggestive content theme(s)? Should this also be considered an opt-in theme category?
Yeah, that should probably be added. I'll get that taken care of. I might remove any/all suggestive content in the future.
Alright, since the spicy content only became available when using mixed mode
, I just removed the content from even showing up.
Updated the documentation, removing the suggestive theme section. And also animated the link hovering effect See this discussion.
removing the suggestive theme section.
That's fair, it's still there (for the Chrome Themes), but the user has to go out of their way to install it. So they aren't being surprised by spiciness.
Description
Motivation and Context
Closes #85
Screenshots (if appropriate):
Types of changes
Checklist: