Closed ZimCodes closed 2 years ago
Ready for review!
Since this still has the stuff from #86 (which hasn't been merged yet), I'm just going to include it in there https://github.com/doki-theme/doki-theme-web/pull/86/commits/9d6123fe26fcfe1907d1774bc4a49b5e6fd44eae and close this pr. Thanks for putting the effort in for creating the pr though.
The changes presented here are mostly bug fixes & tune-ups before publication to the marketplace.
Description
The main goal of this pr is to address the following issues:
Secondary Button in Druthers
I've noticed when switching from a character that does not have a secondary background to a new character that has a secondary background in druthers, the secondary background checkbox will not appear until after clicking Apply. Performing the opposite sequence, the secondary background checkbox will still be visible until Apply is clicked.
This is an issue as now the character that does not have a secondary background will have a visible secondary background checkbox indicating it does have a secondary background.
Secondary Button Refresh
When clicking the secondary background checkbox the Options Page does an unnecessary refresh. The Options Page does not need to be included in the refresh sequence as no secondary theme is applied here.
New Settings Button
Right now the settings button does not have a complete indication of a clickable link. For the most part, it is missing important pseudo class(es) which defines its affordance, specifically
hover
.Motivation and Context
https://github.com/doki-theme/doki-theme-web/pull/86#pullrequestreview-847202640
Screenshots (if appropriate):
Extra Refresh Problem
https://user-images.githubusercontent.com/23222943/148665879-97f549b6-3b68-4bb0-a435-7505c967349b.mp4
Secondary Button Problem
https://user-images.githubusercontent.com/23222943/148665904-5a594b86-2022-47bc-926a-863f9d8d448b.mp4
Types of changes
Checklist: