doki-theme / doki-theme-web

Cute anime character themes for your Chrome, Edge, & Brave browser.
MIT License
154 stars 15 forks source link

Build 74.0 themes #90

Closed R0dn3yS closed 2 years ago

Unthrottled commented 2 years ago

Hey! Thanks for the work you've put in so far, I appreciate it.

However you chose probably the plugin update most tightly coupled to my build set up. 😅

There is a fair amount of re-work that needs to be done with this.

I have a few options for you:

  1. I can make the necessary changes for you to be able to completely provide the update, then follow up and request changes.
  2. I can provide the update, and then make the necessary changes for you to contribute next time, but contribute you as a co-author (Because if I took this PR, it is easier me to revert the commits provided and re-run the build process again). Then I can follow up with what changes would need to be done for the next release in this PR.

Trying to guess why you've submitted build updates for plugins out of nowhere. I assume you are either trying to help me or broaden your contributions. I am also not trying to not sound like a jerk 😃

To be honest, I was saving web for last because I was planning on pulling out Firefox, doing it a bit different, and putting it in its own repository.

R0dn3yS commented 2 years ago

You can provide the update yourself if that is easier. As to why I provided the updates myself was because i wanted to use one of the new themes on chrome/github, and because I'm interested in this project as a whole.

Unthrottled commented 2 years ago

That makes sense! Normally, I can get all the updates in the same day I release the master build. However, I've had to field a lot of other issues in other stuff I maintain since releasing (those are just excuses tho).

Anyways, if you are interested, once I am done with the updates. I can review both requests, and you pointers for next time. If not, no worries.

R0dn3yS commented 2 years ago

I would appreciate the pointers, I'd like to try making my own themes but I had some problems setting everything up.

Unthrottled commented 2 years ago

I'd like to try making my own themes

Cool! I'll accept theme contributions, as long as you fine with me making/requesting any adjustments to make it align with my vision of themes.

Unthrottled commented 2 years ago

Not 100% sure, but I think that the mass change to all the images has to do with the fact that the build script pulled all the images from doki-theme-assets. That one isn't your fault.

I think that I'm going to change how/where the images are pull from, so that is subject to change. However, whatever I decide on, other people will be able to use it as well. I'll provide more details when that is dun.

One thing that I am currently doing is having to set the transparent backgrounds of all the wallpapers to baseBackgroundColor because I think firefox doesn't handle the transparency very well, see https://github.com/doki-theme/doki-theme-web/blob/bf93ce316678da8a18a78fef337539cf6880e108/chromeThemes/Misaka%20Mikoto's%20Theme/images/mikoto_dark.png as example.

R0dn3yS commented 2 years ago

The contributing file is really helpful, the only thing that isn't clear is where the images come from. Also just wondering where do you get your backgrounds from? Do you make them yourselves, or do you have another source?

Unthrottled commented 2 years ago

the only thing that isn't clear is where the images come from

Yeah that one was my bad. I should have been putting them in the doki-theme-assets repo.

Also just wondering where do you get your backgrounds from? Do you make them yourselves, or do you have another source?

Most of the backgrounds used are SVGs that I created from existing works. That way I can scale up the asset without loosing quality. (Who knows I might get 4k monitor in the future. :)

I typically look around images, then base a theme around an image that I like (It shows the character well, is usable to have in the background, has a good color scheme, etc).

Here are the assets I used for this build: Rikka Nadeshiko
rikka_cover wp8941587
Mikoto Raphtalia
maxresdefault 91384f26438e8d5c6866dc198cc0b5da

And that's the part that takes forever, building the color schemes is less work.

Unthrottled commented 2 years ago

Circling back, finally got around to completing the extraction of the firefox to https://github.com/doki-theme/doki-theme-firefox

Thanks for your interest, will be closing this.