Implement network configuration

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku

MIT License

169 stars 44 forks source link

Implement network configuration #102

Closed Guerlielton closed 3 years ago

Guerlielton commented 3 years ago

Do you think It may be possible to network from a module? On dokku_network. for example

services:
  web:
     build: . 
      links: 
         - "db:database"
  db:
      image: postgres

I sometimes coded with python actually, but maybe I could have a look if this feature may interest you and I found sometime later.

josegonzalez commented 3 years ago

@ltalirz Just a note, we support specifying an associated app network, but not necessarily specifying --link except through docker options.

ltalirz commented 3 years ago

hi @Guerlielton - that certainly sounds doable. As @josegonzalez mentions you would need to call docker directly but that is not a problem.

Writing an ansible module is really quite straightforward, I suggest you have a look at the dokku_proxy for example, and see the contributing guide for local setup. Feel free to get started!

On a more general note, this issue touches on one feature that is currently missing in dokku, namely support for docker-compose. @josegonzalez and I were just discussing potential formats for writing down the configuration of an app - what are your thoughts on the docker-compose.yaml?

josegonzalez commented 3 years ago

I think we have support for dokku_docker_options which may work for arbitrary flags (though in this case, a dedicated library that interacts with the network plugin is best).

I don't think docker-compose support made a ton of sense in the past - PR here - but maybe make more sense now? The biggest issues I see are:

lack of zero downtime support
we'd have to figure out a way to properly inject the Docker images instead of having docker-compose rebuild
how do we - and do we? - stop compose from starting certain containers?

Probably worth a separate discussion, but this is a bit more possible with custom builders and schedulers. Let me know if you want to talk about this on slack :)

ltalirz commented 3 years ago

Just mentioning the open PR by @lemoony on this in case someone else wants to have a look at it

ltalirz commented 3 years ago

@Guerlielton Does https://github.com/dokku/ansible-dokku/pull/108 address your use case?

Guerlielton commented 3 years ago

I think yes, I will test in my case thanks for feedback @ltalirz and @lemoony congrats for good job. I will close this issue