search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

Implement Resource limits and reserves Modules #104

Closed apavanello closed 3 years ago

apavanello commented 3 years ago

PR ref #103

Add two new lib files (library/dokku_resource_limit.py and library/dokku_resource_reserve.py) and update Readme

apavanello commented 3 years ago

Hi,

Maked changes on source to create a correct README and maked a allowed_keys to be agnostic, in fact i don't need check the output of dokku --quiet resource:limit myapp because the output will have only two returns, the full list of resources (even when no have limits/reserves) and the error (when the app doesn't exist), so i use the current output to generate the allowed_keys list, when dokku add new resources no need to change the list

In test subject, i created a branch in my repo and added some tests and all have pass (you can check in my github actions https://github.com/apavanello/ansible-dokku/actions/runs/818794950), when #98 be fixed i can make another PR to implement the resources tests

Sorry for english mistakes,i still learning the language

apavanello commented 3 years ago

@ltalirz all done, changes sugested are maded.