search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

Add dokku_letsencrypt library method #105

Closed gavinballard closed 3 years ago

gavinballard commented 3 years ago

Closes #9, by adding a simple library method that can be used to enable or disable Let's Encrypt on a specific application.

This took a slightly different approach to the existing draft implementation in #49.

gavinballard commented 3 years ago

Thanks for the speedy response @ltalirz!

I was keen to add a test but without an example to copy from I wasn't confident (and sounds like it's not feasible in any case given your comments on #98). This method is pretty simple and I've been using it in production, so I think it's a fair call to bring it in anyway.

Added a couple of responses to your comments, LMK what you think and I'll update accordingly.

ltalirz commented 3 years ago

by the way, since I don't use the letsencrypt plugin, could you please comment on whether your PR also addresses https://github.com/dokku/ansible-dokku/pull/49 ?

gavinballard commented 3 years ago

Hey @ltalirz, I've addressed the couple of comments with a renamed method and more sensible checking.

by the way, since I don't use the letsencrypt plugin, could you please comment on whether your PR also addresses #49 ?

Yes, that PR won't be needed once this is merged so it could be closed out.

Thanks!

ltalirz commented 3 years ago

I'll tag a new version once https://github.com/dokku/ansible-dokku/pull/104 is merged as well