search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

make more use of `module_utils` #106

Closed ltalirz closed 2 years ago

ltalirz commented 3 years ago

Make use of module_utils/ -- they’re your friends

– basic.py – api.py – facts/ – urls.py – six.py – noteworthy others: ec2.py, docker.py, database.py, mysql.py, powershell.ps1 — and many many more

See also ansible docs

Besides reusing functionality provided by ansible, there is also a ton of code duplication in the dokku_ modules, i.e. the first step would be just to remove that.

ltalirz commented 3 years ago

Code duplication reduced in f2157815bcc5fee4a7361269b4c0e2c4156f5552

It's possible that one could/should still replace some functionality with ansible's module_utils

ltalirz commented 2 years ago

Not going to continue along this route for the moment. Happy to reopen if someone wants to pick this up.