Closed lemoony closed 3 years ago
P.S. Would be great to add a short test to the verify playbook.
Hi @ltalirz , thanks for the feedback! I already applied most of your suggestions. I will also try to add a test the next couple of days an then request a new review :)
Hi @ltalirz , thanks for the feedback! I already applied most of your suggestions. I will also try to add a test the next couple of days an then request a new review :)
Thanks a lot, much appreciated!
Hi @ltalirz, from my point of view i've addressed every issue. I've added some basic tests for network management. If we want to have more thorough tests, maybe its worth the effort to split verify.yml
up into multiple files (otherwise it gets to confusing i guess).
If you find the time, would be great to have another review on it. Thanks!
And dropped new release https://github.com/dokku/ansible-dokku/releases/tag/v2021.9.3
Partly addresses #102 .
This PR basically allows to create a network and attaching apps to it.
Added two new library files:
Updated README.md