Open ltalirz opened 3 years ago
I feel like we should deprecate one and only support the official method? And eventually delete the old one.
We should just delete it. The git-sync
plugin isn't even available to anyone except me as the source is private.
Ok, just to confirm: you propose to delete the dokku_git_sync
ansible module, keeping only dokku_clone
? Or the other way around?
Given that the underlying dokku command is dokku git:sync
, dokku_git_sync
would seem to make sense as a name.
On the other hand, dokku_clone
is probably what most users of the ansible role were using since it did not require a commercial plugin.
Yeah delete dokku_git_sync
. In theory, that isn't going to break workflows for anyone, as they were already using dokku_clone
.
Okay I think maybe we should just rename to dokku_git_sync
. That will make most sense to users looking at the official Dokku commands.
Agreed!
Let's deprecate dokku_clone
in favor of dokku_git_sync
, and, after a significant deprecation period (say, 12 months - I assume many people are using dokku_clone
), we can delete the dokku_clone
module.
The
dokku git:sync
command became part of dokku as of version 0.23.0.The
dokku_clone
module of the ansible role was changed to usedokku git:sync
under the hood already. The most straightforward path would probably be to keep bothdokku_clone
anddokku_git_sync
and let them reuse the same python code under the hood (only difference:dokku_git_sync
should havebuild: false
by default, like thegit:sync
command).