search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

decide fate of `dokku_git_sync` module #113

Open ltalirz opened 3 years ago

ltalirz commented 3 years ago

The dokku git:sync command became part of dokku as of version 0.23.0.

The dokku_clone module of the ansible role was changed to use dokku git:sync under the hood already. The most straightforward path would probably be to keep both dokku_clone and dokku_git_sync and let them reuse the same python code under the hood (only difference: dokku_git_sync should have build: false by default, like the git:sync command).

josegonzalez commented 3 years ago

I feel like we should deprecate one and only support the official method? And eventually delete the old one.

josegonzalez commented 2 years ago

We should just delete it. The git-sync plugin isn't even available to anyone except me as the source is private.

ltalirz commented 2 years ago

Ok, just to confirm: you propose to delete the dokku_git_sync ansible module, keeping only dokku_clone? Or the other way around?

Given that the underlying dokku command is dokku git:sync, dokku_git_sync would seem to make sense as a name. On the other hand, dokku_clone is probably what most users of the ansible role were using since it did not require a commercial plugin.

josegonzalez commented 2 years ago

Yeah delete dokku_git_sync. In theory, that isn't going to break workflows for anyone, as they were already using dokku_clone.

josegonzalez commented 1 year ago

Okay I think maybe we should just rename to dokku_git_sync. That will make most sense to users looking at the official Dokku commands.

ltalirz commented 1 year ago

Agreed!

Let's deprecate dokku_clone in favor of dokku_git_sync, and, after a significant deprecation period (say, 12 months - I assume many people are using dokku_clone), we can delete the dokku_clone module.