Closed ltalirz closed 2 years ago
@josegonzalez This reduces the list of supported operating systems to the ones that we test here. Just checking you agree with this.
Isn't Debian 9 Stable or something? I'm happy to drop upstream in the next release if we have good reasoning we can document :)
Well, it seems the nginx repository has dropped it (just like ubuntu 16.04)
TASK [nginxinc.nginx : (Debian/Ubuntu) Configure NGINX repository] *************
failed: [instance] (item=deb [arch=amd64] https://nginx.org/packages/mainline/debian/ stretch nginx) => {"ansible_loop_var": "item", "changed": false, "item": "deb [arch=amd64] https://nginx.org/packages/mainline/debian/ stretch nginx", "msg": "Failed to update apt cache: E:The repository 'https://nginx.org/packages/mainline/debian stretch Release' does not have a Release file."}
failed: [instance] (item=deb-src https://nginx.org/packages/mainline/debian/ stretch nginx) => {"ansible_loop_var": "item", "changed": false, "item": "deb-src https://nginx.org/packages/mainline/debian/ stretch nginx", "msg": "Failed to update apt cache: E:The repository 'https://nginx.org/packages/mainline/debian stretch Release' does not have a Release file."}
Can we conditionally include that recipe? I think nginx from the official repos is new enough for dokku now.
Can we conditionally include that recipe? I think nginx from the official repos is new enough for dokku now.
Can you elaborate a bit on what you're suggesting here? Should we have different code paths for the debian installation depending on the debian version? Or drop the geerlingguy.nginx role for a "manual" installation of nginx altogether?
Drop geerlingguy.nginx
and just install nginx normally. It's also a dependency of dokku so it gets installed anyways...
Drop
geerlingguy.nginx
and just install nginx normally. It's also a dependency of dokku so it gets installed anyways...
Sounds good; will do this in https://github.com/dokku/ansible-dokku/pull/122
In the meanwhile, I'll merge this with the new CI checks (keeping compatibility in the role back to Ubuntu 16.04 and Debian 9) since the failing checks are preventing pushes to ansible galaxy.
On Ubuntu 16.04 the nginxinc.nginx roles fails with
The repository 'https://nginx.org/packages/mainline/ubuntu xenial Release' does not have a Release file.
Seems like it's time to drop support; same for Debian 9.
Fixes #123 since all checks will be working again.