search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

chore: drop nginxinc.nginx role #122

Closed ltalirz closed 1 year ago

ltalirz commented 2 years ago

nginxinc.nginx dropped support for Ubuntu 16.04 and Debian 9. However, installing dokku should install nginx automatically, i.e. the role was unnecessary in the first place.

ltalirz commented 2 years ago

Following @josegonzalez's suggestion here to simply drop the nginxinc.nginx role dependency since nginx should be installed as a dokku dependency anyhow.

The build errors when installing the dokku package; there seems to be an issue with the the nginx service not starting up properly in this case (log)

"Starting nginx (via systemctl): nginx.serviceJob for nginx.service failed because the control process exited with error code.", 
"See \"systemctl status nginx.service\" and \"journalctl -xe\" for details.", 
" failed!", 
"Reloading nginx configuration (via systemctl): nginx.servicenginx.service is not active, cannot reload.", 
" failed!", 
"2021/11/07 21:14:00 exit status 1", 
"dpkg: error processing package dokku (--configure):", 
" installed dokku package post-installation script subprocess returned error exit status 1",

If someone has any pointers as to why that might be, let me know. Otherwise I'll need to find some time at some point to run it on a live machine

josegonzalez commented 2 years ago

Is it because tests are run in docker and there is no systemd in docker?

ltalirz commented 2 years ago

Is it because tests are run in docker and there is no systemd in docker?

Thanks for the suggestion - geerlingguy's docker images that we are using have systemd (see e.g. here); also apt-installing dokku works just fine when the nginxinc.nginx role is run before (as we currently do).

I wonder what nginxinc.nginx does that makes this problem go away...

ltalirz commented 1 year ago

The issue still persists today.

Active support for ubuntu 16.04 ended April 2021, so I personally don't care about supporting it in this role.

Given this, let's not try to fix something that isn't broken. Should someone else be interested in removing the dependency on the nginxinc.nginx role in the future, feel free to continue.